Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210709152909.1.I23eb4cc5a680341e7b3e791632a635566fa5806a@changeid>
 <67ff22da55104dda57a0015e073cdfcc@codeaurora.org>
In-Reply-To: <67ff22da55104dda57a0015e073cdfcc@codeaurora.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Mon, 12 Jul 2021 08:06:10 -0700
Message-ID: <CAD=FV=UOmJpX1Jwkc+U9_S9f1G8Ta46WXPmu0YRT1YadO6rYOA@mail.gmail.com>
Subject: Re: [PATCH] drm/dp: Move panel DP AUX backlight support to drm_dp_helper
To:     Rajeev Nandan <rajeevny@codeaurora.org>
Cc:     Lyude Paul <lyude@redhat.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Robert Foss <robert.foss@linaro.org>,
        =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Sat, Jul 10, 2021 at 3:29 AM <rajeevny@codeaurora.org> wrote:
>
> > @@ -209,18 +208,11 @@ static inline int
> > of_drm_get_panel_orientation(const struct device_node *np,
> >  #if IS_ENABLED(CONFIG_DRM_PANEL) &&
> > (IS_BUILTIN(CONFIG_BACKLIGHT_CLASS_DEVICE) || \
> >       (IS_MODULE(CONFIG_DRM) && IS_MODULE(CONFIG_BACKLIGHT_CLASS_DEVICE)))
>
> Thanks, for the fix. Changes look good to me. I checked this on Trogdor
> Lazor device.
>
> I have one small doubt, shouldn't we add above (or similar) check around
> drm_panel_dp_aux_backlight() in drm_dp_helper source & header files?
> This function is using devm_backlight_device_register() that needs
> CONFIG_BACKLIGHT_CLASS_DEVICE for compilation.
>
> If that's not an issue,
> Reviewed-by: Rajeev Nandan <rajeevny@codeaurora.org>

Indeed you are correct. I tried trying off the
CONFIG_BACKLIGHT_CLASS_DEVICE and it was unhappy. I've posted a v2
which I think fixes this [1]. I left your review tag off to give you a
chance to confirm I didn't goof anything else up in the v2. Thanks!

[1] https://lore.kernel.org/lkml/20210712075933.v2.1.I23eb4cc5a680341e7b3e791632a635566fa5806a@changeid/

-Doug