Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <CAB9dFdvHsLsw7CMnB+4cgciWDSqVjuij4mH3TaXnHQB8sz5rHw@mail.gmail.com>
References: <CAB9dFdvHsLsw7CMnB+4cgciWDSqVjuij4mH3TaXnHQB8sz5rHw@mail.gmail.com> <162609463116.3133237.11899334298425929820.stgit@warthog.procyon.org.uk> <162609464716.3133237.10354897554363093252.stgit@warthog.procyon.org.uk>
To:     Marc Dionne <marc.c.dionne@gmail.com>
Cc:     dhowells@redhat.com, linux-afs@lists.infradead.org,
        Tom Rix <trix@redhat.com>, linux-fsdevel@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] afs: check function return
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3360494.1626103286.1@warthog.procyon.org.uk>
Date:   Mon, 12 Jul 2021 16:21:26 +0100
Message-ID: <3360495.1626103286@warthog.procyon.org.uk>
Precedence: bulk

Marc Dionne <marc.c.dionne@gmail.com> wrote:

> > @@ -777,7 +777,7 @@ int afs_writepages(struct address_space *mapping,
> >                 mapping->writeback_index = next / PAGE_SIZE;
> 
> Isn't there the same issue with the use of next here.

Good point.

> >                         mapping->writeback_index = next;
> 
> Unrelated to this patch, but since next is a byte offset, should this
> also divide by PAGE_SIZE as above.

Also a good point.  I'll whip up a separate patch for that.

David