Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: mdtipton=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 01AB0C433D3
From:   Mike Tipton <mdtipton@codeaurora.org>
Subject: Re: [PATCH 2/4] interconnect: Always call pre_aggregate before
 aggregate
To:     okukatla@codeaurora.org
Cc:     djakov@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org,
        saravanak@google.com, linux-arm-msm@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        mdtipton=codeaurora.org@codeaurora.org
References: <20210625212839.24155-1-mdtipton@codeaurora.org>
 <20210625212839.24155-3-mdtipton@codeaurora.org>
 <000574efe90897c1738299cfba4fea7d@codeaurora.org>
Message-ID: <d847ed42-e6ba-1686-f753-7dfecd7efa57@codeaurora.org>
Date:   Mon, 12 Jul 2021 08:39:57 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <000574efe90897c1738299cfba4fea7d@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/1/2021 11:55 AM, okukatla@codeaurora.org wrote:
> On 2021-06-26 02:58, Mike Tipton wrote:
>> The pre_aggregate callback isn't called in all cases before calling
>> aggregate. Add the missing calls so providers can rely on consistent
>> framework behavior.
>>
>> Fixes: d3703b3e255f ("interconnect: Aggregate before setting initial 
>> bandwidth")
>> Signed-off-by: Mike Tipton <mdtipton@codeaurora.org>
>> ---
>>  drivers/interconnect/core.c | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
>> index 945121e18b5c..cfd54c90a6bb 100644
>> --- a/drivers/interconnect/core.c
>> +++ b/drivers/interconnect/core.c
>> @@ -973,9 +973,12 @@ void icc_node_add(struct icc_node *node, struct
>> icc_provider *provider)
>>      }
>>      node->avg_bw = node->init_avg;
>>      node->peak_bw = node->init_peak;
>> -    if (provider->aggregate)
>> +    if (provider->aggregate) {
>> +        if (provider->pre_aggregate)
>> +            provider->pre_aggregate(node);
> nit: we can invoke pre_aggregate() out side of if (qcom_icc_aggregate).

Sure, will update this.

> 
>>          provider->aggregate(node, 0, node->init_avg, node->init_peak,
>>                      &node->avg_bw, &node->peak_bw);
>> +    }
>>      provider->set(node, node);
>>      node->avg_bw = 0;
>>      node->peak_bw = 0;