Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3109486pxv; Mon, 12 Jul 2021 09:29:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzimAcMHBKCqBMxw1eNRHocCKWvlDNQXiHeRpYDcW9YUsosYXU0YCgQhBQ1LveubWKyDkM1 X-Received: by 2002:a02:aa8b:: with SMTP id u11mr39308222jai.43.1626107375298; Mon, 12 Jul 2021 09:29:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626107375; cv=none; d=google.com; s=arc-20160816; b=jVqqfMk3Eu/XJN1bP+SHDmBSwk6CLD8eeKun3udq8ohCHT/GU1zDVzAPqSsIjzhZXp HzH2rCVIIbyWn7neXzTdaZM04fgY/a5PEENP5Vw9Y7TaPocSvntlxMlJdZ5VkbYZk9Jt dJci4aafSYcqFc0ZGB7kAoo+6P5NaHZaiVJ6OXqxFi7zeuiMTn/StPfDqbUoIn1NCLPD FvK1hQ9ijZPC990yWkg42/ArG9y+fBHeDj7+8tk42RBGPntImbg276DOt2umaJNKJ1Co RKTZ22aiPFVKBxaWmGBJiKytRfWhdGOO9VcnlUs1N+toGIbj2EEx35sCpPpfTR5HzF+F PodA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:organization:dkim-signature; bh=orCuv0fOYAe+Okpsh58dcgcFPjvYhZB+nzgzSfjkEXM=; b=tWF7UvQpFEgzKqqWmEGg0K9qtx0YZM+lwVpgQ9d/NtMkuryFuX0M7ORHv4fbWf7O5r boUEO/ergSV6Qk0fd2g9rF5bs1NmGR6Y5R2LSdyrwXcfyPiPvD1ssBF69hWCksYm27xp M2g2h86LbjoICw1WtDSI4pUYOMx3nK3xePA34Fw3+SRc66RJdEYig+SpDStNtdz0+FY8 U9ZaZgdrkjTk4XKSg6rLW4o2UPTl2RyQE8l+5xVOYSV5FFe/vD/SGoSCqVI7QiSs89Zy IPTnuacBN2hdT0Zel1I0/ROo/o7u3lSvsaEJiTjgyFcZmuI6Qpupz6sqpRBpV35SLn+F 8kwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XUbJInrw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o3si6715487ilc.27.2021.07.12.09.29.22; Mon, 12 Jul 2021 09:29:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XUbJInrw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234540AbhGLQa5 (ORCPT + 99 others); Mon, 12 Jul 2021 12:30:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46760 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233939AbhGLQa4 (ORCPT ); Mon, 12 Jul 2021 12:30:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626107287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=orCuv0fOYAe+Okpsh58dcgcFPjvYhZB+nzgzSfjkEXM=; b=XUbJInrwq08Elhww+nLjePYqVAt37xrsIBD+UylYqLksQPSY8iQ49kWMkOD0KKC42/Cuef LlMts5zqo1VxdPA+h/ExD/34q5DYMzfXOU5M6KccwUoTux2EWcdHNUNhLT84wryyAgl4Uk wUG5TmkXsvN7II3GnD1OqtjZ83MM2Bw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-J6-s0ueaND2X06Du1j8bqA-1; Mon, 12 Jul 2021 12:28:06 -0400 X-MC-Unique: J6-s0ueaND2X06Du1j8bqA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4DF81362FB; Mon, 12 Jul 2021 16:28:05 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-118-19.rdu2.redhat.com [10.10.118.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 31DCC60936; Mon, 12 Jul 2021 16:28:04 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH v2 3/4] afs: Fix setting of writeback_index From: David Howells To: linux-afs@lists.infradead.org Cc: Marc Dionne , dhowells@redhat.com, Marc Dionne , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 12 Jul 2021 17:28:03 +0100 Message-ID: <162610728339.3408253.4604750166391496546.stgit@warthog.procyon.org.uk> In-Reply-To: <162610726011.3408253.2771348573083023654.stgit@warthog.procyon.org.uk> References: <162610726011.3408253.2771348573083023654.stgit@warthog.procyon.org.uk> User-Agent: StGit/0.23 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix afs_writepages() to always set mapping->writeback_index to a page index and not a byte position[1]. Fixes: 31143d5d515e ("AFS: implement basic file write support") Reported-by: Marc Dionne Signed-off-by: David Howells Link: https://lore.kernel.org/r/CAB9dFdvHsLsw7CMnB+4cgciWDSqVjuij4mH3TaXnHQB8sz5rHw@mail.gmail.com/ [1] cc: linux-afs@lists.infradead.org --- fs/afs/write.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/afs/write.c b/fs/afs/write.c index 1ed62e0ccfe5..c0534697268e 100644 --- a/fs/afs/write.c +++ b/fs/afs/write.c @@ -784,7 +784,7 @@ int afs_writepages(struct address_space *mapping, } else if (wbc->range_start == 0 && wbc->range_end == LLONG_MAX) { ret = afs_writepages_region(mapping, wbc, 0, LLONG_MAX, &next); if (wbc->nr_to_write > 0 && ret == 0) - mapping->writeback_index = next; + mapping->writeback_index = next / PAGE_SIZE; } else { ret = afs_writepages_region(mapping, wbc, wbc->range_start, wbc->range_end, &next);