Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <b8db79e6857c41dab4ef08bdf826ea7c47e3bafc.1615947283.git.josef@toxicpanda.com>
 <CAAd53p5Vh_+tUeEQx3xf_aLiCiKP1u5Y3VgYCUzZ82Kgtr-iYw@mail.gmail.com>
 <bebcaffc-d485-912d-0c42-c0781f9c7603@toxicpanda.com> <CAAd53p7eJk9EtMTLjB5i7RdoKA3WS1W4TRjQs08adi7iAux_jQ@mail.gmail.com>
 <78dfcd55-442d-dcc0-c37f-5576f65f91b5@toxicpanda.com> <CAAd53p6Lp8+S0yjWi=MikQJ_zywiWamUS5p19oKoqB6uYW8jzg@mail.gmail.com>
 <0cd8b39e-3feb-87b8-e172-70b07692b82a@toxicpanda.com> <CAAd53p6=dGwtTVBcQuO+Rvt0nZ2Ck_OXtR=um=S2p=OjNXnH8w@mail.gmail.com>
In-Reply-To: <CAAd53p6=dGwtTVBcQuO+Rvt0nZ2Ck_OXtR=um=S2p=OjNXnH8w@mail.gmail.com>
From:   Kai-Heng Feng <kai.heng.feng@canonical.com>
Date:   Tue, 13 Jul 2021 01:03:49 +0800
Message-ID: <CAAd53p6E8rMDHDRRmvZKyt7YJ_b5m3RPQH312RU0d7-tbXu6VA@mail.gmail.com>
Subject: Re: [PATCH][RESEND] Revert "PM: ACPI: reboot: Use S5 for reboot"
To:     Josef Bacik <josef@toxicpanda.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        "kernel-team@fb.com" <kernel-team@fb.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Mar 20, 2021 at 12:23 AM Kai-Heng Feng
<kai.heng.feng@canonical.com> wrote:
>
> On Fri, Mar 19, 2021 at 3:02 AM Josef Bacik <josef@toxicpanda.com> wrote:
> >
> > On 3/18/21 1:42 AM, Kai-Heng Feng wrote:
> > > On Thu, Mar 18, 2021 at 1:25 AM Josef Bacik <josef@toxicpanda.com> wrote:
> > > [snipped]
> > >> "shutdown now" works fine with and without your patch.  Thanks,
> > >
> > > Rafael,
> > > Please revert the patch while we are working on it.
> > >
> > > Josef,
> > > Can you please test the following patch:
> > >
> >
> > That made it work fine.  Thanks,
>
> So there are things depend on reboot or shutdown to carry out
> different behaviors.
> Can you please find whether there is any code path uses SYSTEM_RESTART
> or SYSTEM_POWER_OFF that leads to different behavior? Most likely
> happen in a driver's .shutdown callback.

A gentle ping...

>
> Kai-Heng
>
> >
> > Josef