Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     'Matteo Croce' <mcroce@linux.microsoft.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        Jens Axboe <axboe@kernel.dk>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Lennart Poettering" <lennart@poettering.net>,
        Luca Boccassi <bluca@debian.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Damien Le Moal <damien.lemoal@wdc.com>,
        Tejun Heo <tj@kernel.org>,
        =?iso-8859-1?Q?Javier_Gonz=E1lez?= <javier@javigon.com>,
        Niklas Cassel <niklas.cassel@wdc.com>,
        Johannes Thumshirn <johannes.thumshirn@wdc.com>,
        Hannes Reinecke <hare@suse.de>,
        Matthew Wilcox <willy@infradead.org>,
        Christoph Hellwig <hch@infradead.org>,
        JeffleXu <jefflexu@linux.alibaba.com>
Subject: RE: [PATCH v4 3/5] block: add ioctl to read the disk sequence number
Thread-Topic: [PATCH v4 3/5] block: add ioctl to read the disk sequence number
Thread-Index: AQHXdn3YesUJw94QbkmEhR2/eed3Hqs/txkg
Date:   Mon, 12 Jul 2021 19:22:43 +0000
Message-ID: <TU4PR8401MB10558BB52D2F37CFC96FB8B8AB159@TU4PR8401MB1055.NAMPRD84.PROD.OUTLOOK.COM>
References: <20210711175415.80173-1-mcroce@linux.microsoft.com>
 <20210711175415.80173-4-mcroce@linux.microsoft.com>
In-Reply-To: <20210711175415.80173-4-mcroce@linux.microsoft.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ePHkzP5cAte0fh/ydosJRI0OIsNF1XzgtUTebMejbWhrBNq5wk89KIfW00?=
 =?iso-8859-1?Q?OfGMMKy8SnvJMdT6SABi5DtwDidlxlTeh+a1tapNZKxw7vjH8pw3QL6+gg?=
 =?iso-8859-1?Q?5d+NAoGr0D58zfD4mHhmw1srQCCMSH0+LUgcNNKkr1UeV9v1apTI+FZBDL?=
 =?iso-8859-1?Q?V3TmKXHPf9LZMWimN+PurKBz82k0rCdMBdGs4cR93BUkb8QW4ZuQW1Z66P?=
 =?iso-8859-1?Q?8OoW5ZJUIho0D1/WRUhrlGQUMY0ZiGeKwf4uBSMhuCMlVMu8nD6HZ1Rap8?=
 =?iso-8859-1?Q?t+FpswwhoSHEAhE0KNTn7+/7WbRBUDAHog8foLYThOiYmhyx6vh30Y7DP7?=
 =?iso-8859-1?Q?mC9ezKU+bO092FryUBHtAH5aEz4DKMtJ24/3NImIeU4n1/oGQ8h6LANAcd?=
 =?iso-8859-1?Q?iw8n8ydicow6W7a0HQjCATGBappdqk4GE5rL3lIgEJeFh3R2gSZF24NnnQ?=
 =?iso-8859-1?Q?BlqafY4s4HEpHpYdo2gbWVj7vJhxPNa1u0Pv7/F3TGKkak7giwbEUwiLs6?=
 =?iso-8859-1?Q?+EDOR+QKP6JyJj/i9AoKxB63h0ynMX2B9V+LM3YnjZ6W7ohJZz6ZIZ0GJn?=
 =?iso-8859-1?Q?jzljgxL9w7NWbcZ0Y8WE7q597vZMT8g0vEuxraZbqymOYH/iAWIxVYnEpm?=
 =?iso-8859-1?Q?pf8wlobeZfAOnlBdY9XleHK1mTcdo3qig7Qv6BuJXz9r0KlGD0GfcZnOnO?=
 =?iso-8859-1?Q?p9rRrIugqzAinGgc+MpKKdKozO/WS3fmxH/SZnNg1lEaZfVpLU3aJkQron?=
 =?iso-8859-1?Q?NSHstOArYOnsuSGpJoSwBsHM398DCblaCFnKNAg86kDmAm2Q+WRR4QIwID?=
 =?iso-8859-1?Q?+gcqEkIHU75Cy8hY4rj7c9V6gXGqd5c5NC6OUBvZQ04Ta72g+Dvw3rzYiE?=
 =?iso-8859-1?Q?ZfJWVU2GKRG+/ZhjkZPkzpZ8V3LUSdxhHX9P/rZIglXKX4yIplaKaFFufK?=
 =?iso-8859-1?Q?BvuoqLbh+8j8vUgfdKILMT8tGHv35zzOpcLTSats4XJZr4dUmkKuv+3WTG?=
 =?iso-8859-1?Q?8owwfx/WokXLNDZGie/BHRPhdooqNn9/wgM547ZC9HArb22wUuv+ZPmpRb?=
 =?iso-8859-1?Q?GeBK68grMN66clFB1Hrh0Aso1/mm/DMmoC//0h9DpceAM6RJ1d3w7LUARW?=
 =?iso-8859-1?Q?PxgXAm2mbVf9U8CT1J8FINSBJE1FkWG9Q+rMiP9PN7SqBZf+CA41nHw1qj?=
 =?iso-8859-1?Q?Lw1RghsJuNjdhvuqK8sJaTSHONna2q7QxUYvCkwB0cQyia7/oE9YXAMrZZ?=
 =?iso-8859-1?Q?hlsynTAJz6Miy0hNCxBmF6s+nxvSUaActMriHapAz1AbFIM4E3eu5b8dY9?=
 =?iso-8859-1?Q?+6tzBlN1FAQ8L7ARL2P6A3YUYw6LwbX63VWOKwgMujlxRTFn7uOTXC9aKR?=
 =?iso-8859-1?Q?kvTrmYd8Hg?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TU4PR8401MB1055.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: b852b725-4055-41b0-c015-08d9456a6c8e
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2021 19:22:43.8660
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TWWzbxEk9CWEVeXmMAaDQ/WWX/XLGZ2JPx/llKsfzoh90Vkmv6FkBuDbny3rPx9G
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB0494
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: JEEgrDJXp45stfeLewoTMQ2aB1A2wT8C
X-Proofpoint-GUID: JEEgrDJXp45stfeLewoTMQ2aB1A2wT8C
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-07-12_11:2021-07-12,2021-07-12 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 mlxlogscore=937 priorityscore=1501 impostorscore=0 malwarescore=0
 phishscore=0 clxscore=1011 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2107120137
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Matteo Croce <mcroce@linux.microsoft.com>
> Sent: Sunday, July 11, 2021 12:54 PM
...
> Subject: [PATCH v4 3/5] block: add ioctl to read the disk sequence number
>=20
> From: Matteo Croce <mcroce@microsoft.com>
>=20
> Add a new BLKGETDISKSEQ ioctl which retrieves the disk sequence number
> from the genhd structure.
...


Given:
    static int put_u64(u64 __user *argp, u64 val)
    {
        return put_user(val, argp);
    }

> diff --git a/block/ioctl.c b/block/ioctl.c
> index 24beec9ca9c9..0c3a4a53fa11 100644
> --- a/block/ioctl.c
> +++ b/block/ioctl.c
> @@ -469,6 +469,8 @@ static int blkdev_common_ioctl(struct block_device
> *bdev, fmode_t mode,
>  				BLKDEV_DISCARD_SECURE);
...

> +	case BLKGETDISKSEQ:
> +		return put_u64(argp, bdev->bd_disk->diskseq);

How does that work on a system in which int is 32 bits?