Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3236236pxv; Mon, 12 Jul 2021 12:31:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0q35FBpjH8EbJe55xTfwY/EyrZ0K3gh5oR1AF38Sy+e4Ppa640eWuqtVX5bBI8lGwTyAd X-Received: by 2002:a17:906:5f99:: with SMTP id a25mr726826eju.101.1626118311753; Mon, 12 Jul 2021 12:31:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626118311; cv=none; d=google.com; s=arc-20160816; b=YCQeEPemI6tspxkalyekzVyZzBcggslLbisvjcJDMmcWpDLrPbSuVe6VtJOZzj/0uM YT92Y4iJqe6/8GTuTvx4eVP3r5Rssyu+/cqYleif8ceAyXPLbJzqXfJ7N16zgs4iI3X2 Xi6s/+FQvE1p7ex377mJkp4g7t1vTTOIAjyVJxWzQmO98PPkaTyCTBP4als7/gF0Og3E wSuMsuO2gaGsoV0lG6bEK74vU9rF/Mq+bRvZIzSYGWnnEeODRF9n+3yiuDU+C2Mv9wlq HqBdlMGW6ztDH/K8+CQWfwtO+bIY3YaTUfkADgHUtKus1Kauz8LynPhHhssIwv82UkqT DqfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=r3C0MNcdPuaQMoy2DZLesW5CVXpDYfQzTqrwGXdHaRg=; b=g1Wavh/cfVuyPvXZtPkkveSAH5NUHMIIsyToIWwvUD3bmmOmm54tf6W0PVBJ91No+0 4C9vBcAsmEqnd1CquT+/JQ1zVsApNbV/c758Z14FJAn+uoqEWhZCbW5xGLbD8ZHGd6EK wmnKXrBuZ7b2iELE15Cmx1CH3zOBZIoxijW5q2+My1paJaedxWB+VVe5e7QV+qpOvAgK i/7oNvD5YmmdBLcCW3hW/t9PXVPdwMRWuNXdLVNk61VOLRoGcT2dFI+H6MMM5KMt5sm5 mGqERlMxIYc5hjLvZN0Uywp240jGQyVuLCGm2/46uWAUMdE07mOS9/IqRGstEEgEpouB tzcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b="MJrdQt/x"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d26si17421372edx.496.2021.07.12.12.31.28; Mon, 12 Jul 2021 12:31:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b="MJrdQt/x"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236096AbhGLTdW (ORCPT + 99 others); Mon, 12 Jul 2021 15:33:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235402AbhGLTdV (ORCPT ); Mon, 12 Jul 2021 15:33:21 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FF75C0613DD for ; Mon, 12 Jul 2021 12:30:31 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id u13so6244075lfs.11 for ; Mon, 12 Jul 2021 12:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r3C0MNcdPuaQMoy2DZLesW5CVXpDYfQzTqrwGXdHaRg=; b=MJrdQt/xj/X89L2akDuRIxLQO4djMTLLgU8eBvU6YVC8dUlC07Y6kHh4rBlkT1q7MV Ea7nnfbhd2stzRZFtdTC0KqSjngvfVy93JncJKAiLwNmjmfcozdphfyI2xTiy3uOptFv Vhn12vpbGZd8c3Bo7seoaaiJzsRoQUlb47+hA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r3C0MNcdPuaQMoy2DZLesW5CVXpDYfQzTqrwGXdHaRg=; b=MHqROs3reMyc7ki0+MKYVndS6tdJDCO815CZG2+kB2nzBqzDId0i5THIhswb8AnL/q riNqTkfwpJ2nP8jZY76ro6Hm19ufK++Vx1VhhJRf5gQ/XbT1ED5MrgXyLES0MqQnoVxG v6FM8W9vdVY/VBldqSqz2+M1mLWkgGhKqAr9ECe/hgBc0UEKDYt+Huh/1PIWJK+xEelL G+rJ8ySkw/wReKS8c/bmfg8I982l/8gCCnAJtNLIHDvyoyZnXJdqNxEBEfbsXLGqJBhU ijiWEI3qAlJCMzUbX+8cqZGTjBIfKq1z9qkZcMRnlfv1gRR2J32fOTpEp3uiQErHEAJB SQ8Q== X-Gm-Message-State: AOAM531Vf6IEOT7uKMQt1rYoIBKcJBqXfsOTMpoGdZRJmIt+i3I5Q5Cb wye5cjNOlOKiOIzrTfdZ/RdBMwvO8/g3O/GnBWE= X-Received: by 2002:a19:c38b:: with SMTP id t133mr250342lff.329.1626118229457; Mon, 12 Jul 2021 12:30:29 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id v8sm1679841ljg.137.2021.07.12.12.30.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jul 2021 12:30:29 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id a12so386520lfb.7 for ; Mon, 12 Jul 2021 12:30:29 -0700 (PDT) X-Received: by 2002:a2e:9241:: with SMTP id v1mr639513ljg.48.1626117867421; Mon, 12 Jul 2021 12:24:27 -0700 (PDT) MIME-Version: 1.0 References: <20210712060928.4161649-1-hch@lst.de> In-Reply-To: <20210712060928.4161649-1-hch@lst.de> From: Linus Torvalds Date: Mon, 12 Jul 2021 12:24:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: flush_kernel_dcache_page fixes and removal To: Christoph Hellwig Cc: Andrew Morton , "James E.J. Bottomley" , Russell King , Guo Ren , Thomas Bogendoerfer , Nick Hu , Greentime Hu , Vincent Chen , Helge Deller , Yoshinori Sato , Rich Felker , Geoff Levand , Paul Cercueil , Ulf Hansson , Alex Shi , Linux Kernel Mailing List , Linux ARM , linux-csky@vger.kernel.org, "open list:BROADCOM NVRAM DRIVER" , linux-parisc@vger.kernel.org, Linux-sh list , linux-mmc@vger.kernel.org, linux-scsi , Linux-MM , "open list:DOCUMENTATION" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 11, 2021 at 11:09 PM Christoph Hellwig wrote: > > I think we should just remove it and eat the very minor overhead in > exec rather than confusing poor driver writers. Ack. I think architectures that have virtual caches might want to think about this patch a bit more, but on the whole I can't argue against the "it's badly documented and misused". No sane architecture will care, since dcache will be coherent (there are more issues on the I$ side, but that's a different issue) Linus