Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210712153207.39302-1-willy@infradead.org> <9877bef9-b2e8-6a8c-4d68-7df7f3fb71eb@oracle.com>
In-Reply-To: <9877bef9-b2e8-6a8c-4d68-7df7f3fb71eb@oracle.com>
From:   Mina Almasry <almasrymina@google.com>
Date:   Mon, 12 Jul 2021 12:32:44 -0700
Message-ID: <CAHS8izP7Q8VX+kpzzEUML625aPVOJkUADFs-gnBXWF-QaeKKhA@mail.gmail.com>
Subject: Re: [PATCH] mm: Make copy_huge_page() always available
To:     Mike Kravetz <mike.kravetz@oracle.com>
Cc:     "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        YueHaibing <yuehaibing@huawei.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Peter Xu <peterx@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jul 12, 2021 at 10:52 AM Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
> On 7/12/21 8:32 AM, Matthew Wilcox (Oracle) wrote:
> > Rewrite copy_huge_page() and move it into mm/util.c so it's always
> > available.  Fixes an exposure of uninitialised memory on configurations
> > with HUGETLB and UFFD enabled and MIGRATION disabled.
> >
> > Fixes: 8cc5fcbb5be8 ("mm, hugetlb: fix racy resv_huge_pages underflow on UFFDIO_COPY")
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Reviewed-By: Mina Almasry <almasrymina@google.com>

> > ---
> >  include/linux/migrate.h |  5 -----
> >  include/linux/mm.h      |  1 +
> >  mm/migrate.c            | 48 -----------------------------------------
> >  mm/util.c               | 10 +++++++++
> >  4 files changed, 11 insertions(+), 53 deletions(-)
>
> Thanks Matthew,
>
> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
> --
> Mike Kravetz