Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210713005645.8565-1-zhouzhouyi@gmail.com> <20210713041607.GU4397@paulmck-ThinkPad-P17-Gen-1>
In-Reply-To: <20210713041607.GU4397@paulmck-ThinkPad-P17-Gen-1>
From:   Zhouyi Zhou <zhouzhouyi@gmail.com>
Date:   Tue, 13 Jul 2021 14:16:15 +0800
Message-ID: <CAABZP2zzeVe07Ak0RpN6prwy2_PQoO55WG2XhVy7NG0SnasKAg@mail.gmail.com>
Subject: Re: [PATCH] RCU: Fix macro name CONFIG_TASKS_RCU_TRACE
To:     paulmck@kernel.org
Cc:     josh@joshtriplett.org, rostedt@goodmis.org,
        mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
        joel@joelfernandes.org, rcu@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Thank you very much,
I went through the wordsmithed version, it looks exquisite!

Thank you for your encouragement.
Cheers
Zhouyi

On Tue, Jul 13, 2021 at 12:16 PM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> On Tue, Jul 13, 2021 at 08:56:45AM +0800, zhouzhouyi@gmail.com wrote:
> > From: Zhouyi Zhou <zhouzhouyi@gmail.com>
> >
> > Hi Paul,
> >
> > During my studying of RCU, I did a grep in the kernel source tree.
> > I found there are 3 places where the macro name CONFIG_TASKS_RCU_TRACE
> > should be CONFIG_TASKS_TRACE_RCU instead.
> >
> > Without memory fencing, the idle/userspace task inspection may not
> > be so accurate.
> >
> > Thanks for your constant encouragement for my studying.
> >
> > Best Wishes
> > Zhouyi
> >
> > Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
>
> Good eyes, and those could cause real bugs, so thank you!
>
> Could you please check the wordsmithed version below?
>
>                                                         Thanx, Paul
>
> ------------------------------------------------------------------------
>
> commit fdcf5524b64f2cc8e6201447644079d9f8d4c821
> Author: Zhouyi Zhou <zhouzhouyi@gmail.com>
> Date:   Tue Jul 13 08:56:45 2021 +0800
>
>     RCU: Fix macro name CONFIG_TASKS_RCU_TRACE
>
>     This commit fixes several typos where CONFIG_TASKS_RCU_TRACE should
>     instead be CONFIG_TASKS_TRACE_RCU.  Among other things, these typos
>     could cause CONFIG_TASKS_TRACE_RCU_READ_MB=y kernels to suffer from
>     memory-ordering bugs that could result in false-positive quiescent
>     states and too-short grace periods.
>
>     Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
>     Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
>
> diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> index cfeb43bfc719..434d12fe2d4f 100644
> --- a/include/linux/rcupdate.h
> +++ b/include/linux/rcupdate.h
> @@ -167,7 +167,7 @@ void synchronize_rcu_tasks(void);
>  # define synchronize_rcu_tasks synchronize_rcu
>  # endif
>
> -# ifdef CONFIG_TASKS_RCU_TRACE
> +# ifdef CONFIG_TASKS_TRACE_RCU
>  # define rcu_tasks_trace_qs(t)                                         \
>         do {                                                            \
>                 if (!likely(READ_ONCE((t)->trc_reader_checked)) &&      \
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 27b74352cccf..a8e3acead6f6 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -1498,17 +1498,17 @@ static void noinstr rcu_dynticks_task_exit(void)
>  /* Turn on heavyweight RCU tasks trace readers on idle/user entry. */
>  static void rcu_dynticks_task_trace_enter(void)
>  {
> -#ifdef CONFIG_TASKS_RCU_TRACE
> +#ifdef CONFIG_TASKS_TRACE_RCU
>         if (IS_ENABLED(CONFIG_TASKS_TRACE_RCU_READ_MB))
>                 current->trc_reader_special.b.need_mb = true;
> -#endif /* #ifdef CONFIG_TASKS_RCU_TRACE */
> +#endif /* #ifdef CONFIG_TASKS_TRACE_RCU */
>  }
>
>  /* Turn off heavyweight RCU tasks trace readers on idle/user exit. */
>  static void rcu_dynticks_task_trace_exit(void)
>  {
> -#ifdef CONFIG_TASKS_RCU_TRACE
> +#ifdef CONFIG_TASKS_TRACE_RCU
>         if (IS_ENABLED(CONFIG_TASKS_TRACE_RCU_READ_MB))
>                 current->trc_reader_special.b.need_mb = false;
> -#endif /* #ifdef CONFIG_TASKS_RCU_TRACE */
> +#endif /* #ifdef CONFIG_TASKS_TRACE_RCU */
>  }