Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Jul 2021 08:58:11 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     pandith.n@intel.com
Cc:     arnd@arndb.de, linux-kernel@vger.kernel.org, furong.zhou@intel.com,
        mgross@linux.intel.com, mallikarjunappa.sangannavar@intel.com,
        andriy.shevchenko@linux.intel.com,
        lakshmi.bai.raja.subramanian@intel.com
Subject: Re: [PATCH V5 1/1] misc: NOC Probe Counters
Message-ID: <YO05g5JiOcF/bFza@kroah.com>
References: <20210713065347.21554-1-pandith.n@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210713065347.21554-1-pandith.n@intel.com>
Precedence: bulk

On Tue, Jul 13, 2021 at 12:23:47PM +0530, pandith.n@intel.com wrote:
> --- /dev/null
> +++ b/drivers/misc/noc/Kconfig
> @@ -0,0 +1,16 @@
> +# Copyright (C) 2019 Intel Corporation
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +
> +config NOC_DSS
> +	tristate "Enable DSS NOC probing"

Please be more descriptive of what exactly this is, it does not make
sense to anyone who does not know what DSS or NOC means.

> +	depends on ARCH_KEEMBAY
> +	default y

You only use 'y' if the machine can not boot without the option.
Otherwise it is left alone.

And what about CONFIG_TEST ability to test build this code?  Without
that, you will get almost no one every building this code to see if
anything breaks over time.

thanks,

greg k-h