Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3672391pxv; Tue, 13 Jul 2021 00:41:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5tABDufvJR904vmSJlcHIJ6g6AhdvWPZwBiOdiK8BCCGHoYLqHUyfon2bkYvMF7CPeI9t X-Received: by 2002:a5d:9585:: with SMTP id a5mr2347603ioo.28.1626162078679; Tue, 13 Jul 2021 00:41:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626162078; cv=none; d=google.com; s=arc-20160816; b=uHqj5hjMcatgCTjO2XIB/tawDeMRfYR2GqOzDXSHO2LcwYKXKEYJtyzariOuyZteoh 5MrK5bF8MVVuODsEyEZz1REWNHpflSx6V716jiJtm2OEn24AHITHqhEvMSJ9S1Nf2HN+ odAx3v80pVbQ/lCxWApOk8RFE13SYmrQaLLMe3HrxlMbx3MIlUu5kOBJSHJuxpDmLP1V t1Uhr0hzUAmZ599+6jo/c4aUYH+miYU7AAOC6xpbFgG3yrEzvYFp58iKUMN3yY5tMnAc DT7n3JAPMr6cx0nzheChR8hU4UEqn091jhzFwR4DiexxZ7tBQ83dXxodcsHQn9xwZHJ3 fcWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=4JN6CzM9HirfRxs2rOqstfPJlSyF7T+HOzziYP5BnHc=; b=W8xL4HA0q8c0x3LvLSqWmIQByZcEFI3UdWUR4Kno1WgmtS1BlfES6+mDyb/ZxpME9t uHyyINmuHFxxHTnfpiHoW3PXe1C80QKPziJgAsgKyvipHFhIN49lbGT5y/pmema+KWIs Pdf/YXxbxQD8SrKcnnwswLIRawbJOjSD4AUr2TUUn9LNmy9FW8BYfpedoe5RqgeiX/pL eFyjeSh/l3S1ekyt6NEA3ACON/avnaRrbO4A+FJ2XX5E60/5iVOKwV9D5J4Pmt+2RaGb TbGjPLd7wE+D+9RSCw2lzeX6zNBBaCXHLLjo6ZgJ3jJhHQtk3A4+iTZyKZNk6BBw7lau FzfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u26si8676568jam.87.2021.07.13.00.41.06; Tue, 13 Jul 2021 00:41:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234356AbhGMHnY (ORCPT + 99 others); Tue, 13 Jul 2021 03:43:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234333AbhGMHnX (ORCPT ); Tue, 13 Jul 2021 03:43:23 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 227CCC0613DD for ; Tue, 13 Jul 2021 00:40:34 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m3D1j-0003y1-4j; Tue, 13 Jul 2021 09:40:23 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1m3D1h-0006Q1-QE; Tue, 13 Jul 2021 09:40:21 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1m3D1h-0000vh-PH; Tue, 13 Jul 2021 09:40:21 +0200 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Greg Kroah-Hartman Cc: kernel@pengutronix.de, Christian Borntraeger , Cornelia Huck , Heiko Carstens , Peter Oberparleiter , Vasily Gorbik , Vineeth Vijayan , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: [PATCH v3 3/5] s390/ccwgroup: Drop if with an always false condition Date: Tue, 13 Jul 2021 09:40:12 +0200 Message-Id: <20210713074014.684791-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210713074014.684791-1-u.kleine-koenig@pengutronix.de> References: <20210713074014.684791-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Patch-Hashes: v=1; h=sha256; i=72HAwW1ge0SaWF88KqTqoq0HiIxYHEA9VDa9pzFS5e8=; m=mnRcCYX4Soun6UkRo/vF3OKbvkroGEUnmAV+HlocHj8=; p=l/VUm/c+DmIdVO+6MJuUdAI6l1YC3XF2DMW0Cfqol+o=; g=f55f0fa1ad1e2a674f85b460588b66f70eaabd61 X-Patch-Sig: m=pgp; i=uwe@kleine-koenig.org; s=0x0D2511F322BFAB1C1580266BE2DCDD9132669BD6; b=iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmDtQzsACgkQwfwUeK3K7AmcmwgAnkT cYRBTBw8fmtt/T5Hqo7TnYjhTn3xGElsbvwXNlEZZtlb07eiXwM5gTX7XkLrxZLdFxzvvKB1gQr3c f3aZHIrxdxFjti0ktTfzM5kdQX9Qid3uHozGyJMxdbD2PEOEDYh+w0BDo8FyJsNYfwiLmyTbKzKHN wkFoDaX5rqQZGwEXADGjdA76yxv26zIUBtx2yQyWgAbMwk2OcVEFxRW/ddPMyGEgTpyNmrDjQrUWz xaKau85Mq/z+svqzFSCht5SYVmi3mzMrIuySvqWvz4jmHmHZ5VEbZCI5McuW99V/KG//TBftwqD84 Qcn9Pd8fGoAjKIMo4YPNCBRQ41bKMTQ== Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver core only calls a bus remove callback when there is a driver. So dev->driver is never NULL and the check can safely be removed. Reviewed-by: Cornelia Huck Acked-by: Vineeth Vijayan Signed-off-by: Uwe Kleine-König --- drivers/s390/cio/ccwgroup.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c index 9748165e08e9..a6aeab1ea0ae 100644 --- a/drivers/s390/cio/ccwgroup.c +++ b/drivers/s390/cio/ccwgroup.c @@ -444,8 +444,6 @@ static int ccwgroup_remove(struct device *dev) struct ccwgroup_device *gdev = to_ccwgroupdev(dev); struct ccwgroup_driver *gdrv = to_ccwgroupdrv(dev->driver); - if (!dev->driver) - return 0; if (gdrv->remove) gdrv->remove(gdev); -- 2.30.2