Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 8ZMRd4Bu/rH0m2o4Pz+BPsndzUSUZegV1QJauWbS1uzptfS1QaLQnIzL3DWakH3hEvPrVUoPTU
 AYLibmVppCin0uG+XOl6XGgvDiQKWeiAJxTsq8hNt0Jg9E8vHmLvGtLCfguAiuHKJZmH7emd4+
 vX35UMpbny/Auc6eY/dXhXO0eLEmy2JgKQ7TOrerkSj/lzjydXMf8uOEETJ3ZtD61LRjTW60JB
 +OMrs/D+ZtG7Jgki3nn9QoD3d8kPCpH5q17jTgP8wklu7fqfhcfq02kdjW0GjccfD1Ve5Er+Xn
 Geg=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     "oracleks043021@gmail.com" <oracleks043021@gmail.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "kenny.gibbons@oracle.com" <kenny.gibbons@oracle.com>,
        "kimito.sakata@oracle.com" <kimito.sakata@oracle.com>,
        "rkamdar@micron.com" <rkamdar@micron.com>,
        "chris@printf.net" <chris@printf.net>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
CC:     "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1] mmc-utils: Fix for Firmware Version string printing
Thread-Topic: [PATCH v1] mmc-utils: Fix for Firmware Version string printing
Thread-Index: AQHXd6jZuUgr4o2JXEGNxXFkZDju7qtAidaQ
Date:   Tue, 13 Jul 2021 08:00:23 +0000
Message-ID: <DM6PR04MB65754DC90E423A79D80263C1FC149@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20210713053458.1441-1-oracleks043021@gmail.com>
In-Reply-To: <20210713053458.1441-1-oracleks043021@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ka4l+86LcOHRlV/ZNikYAIiD5QL5FEvvlDVcSA2GPHpebMNgzRpXGB9+Cgk0?=
 =?us-ascii?Q?HG1is7NI6C0B98xrpcJ+rw/kE+EwOyokk8LO67l9/pHhsYS2iwQBu9jfVpoM?=
 =?us-ascii?Q?lFVFunQBk814QDMlpJrsjQEmsVgRGAeVOYm47O9si0GB7y3kzOS58gAxDFNE?=
 =?us-ascii?Q?GihHq0IyLjd7ZppXMHmq8wRqP4qH3u3LF3Z+qVuHej2ANfbMmYBiJy8w8Glr?=
 =?us-ascii?Q?iuM3ok8vdrqC4OW3ny+Icg6Dp+mGF2wMfs5FHwjcixJj/7xde0HHd147bMZl?=
 =?us-ascii?Q?5OaGcCxjUyi35g2qcGbTQJOws86zgpM8rGbj5jCXfXkWjdIzdheM8JOYuevR?=
 =?us-ascii?Q?2xg8ppfeqojrNo4jYa3XLnSsnoO4dI/8XPc7BTVkVqR+IvpAg978lJ/T1j/D?=
 =?us-ascii?Q?apJzvegGwc34OpgKoe1uNR4ofP9NZ2n+1YZhPt4wjB6O1ORLJTOQ3zek4VLn?=
 =?us-ascii?Q?WLhzDYHmukYAvcR7WB/Ysb7+uVw/6FaxNbOywnwcIMChz7SQlWhXFUxsQ/yF?=
 =?us-ascii?Q?gtRrXXvgcCVWJAso/nUFUKMpEJR9lCV3j1Ea6igHKiy/EV47r3AZxlgSmmjg?=
 =?us-ascii?Q?uN70CZrGHXEGE/8EswvyGeVg3wUKuQ72Ni364HET9G5a1/7mS0BXaRKqFlu8?=
 =?us-ascii?Q?XnAtT1JCwG5O/80mUaQ2wuewfkkBR9d+3ypcsPmrv0gVDpj8YufVlzs8BkMM?=
 =?us-ascii?Q?ow3Y7EsMS6r6JmemXvWSkQ/XXrRpBVkuEe3FUzqWK4Sacq9yy07FBlibqKyl?=
 =?us-ascii?Q?SDXRECeZlnL7XXGTsvEQuWTlFEphxVDFd5BdeEODBMUKP8wqw/MGZb1m+eHr?=
 =?us-ascii?Q?JyVkoFqNxM308s5M/bgg2CjQ9GI95k4nCO6/zP/cf1Qq2TEf+YwUZzl6/dST?=
 =?us-ascii?Q?1piUZ0652sMDTll5HQl5wKfXIchkKzmtpyKJa737o1/3wfKUTgDi3n9DB/V1?=
 =?us-ascii?Q?EMy2WJq7l7txvsRNGeO0mkfTulgAg7T8IXOmLQIMo3IwHjLpUsL2VU/nb20D?=
 =?us-ascii?Q?r+22S+x/1EJMVX0ytlym3Va3NsiZLsY9/vwyStE/+MC8JDA9AzRTX8AWMjHg?=
 =?us-ascii?Q?VavKNGZK3NalelPwKDUfMPCzkr0+/UYAmP6NWrntiOj0lplPf4M/302wFPrb?=
 =?us-ascii?Q?ZzDQfujh59Ea5B8nqSDKMELAebCJBIqFCQNtK3GZhU6PUTb2VFYwP4xc0McM?=
 =?us-ascii?Q?NhWQtRLYPXZhl+NJO9zXaE8LFt7Rf2AhA5M+gi0mGLBaDOsV8I3cCozy+Pqb?=
 =?us-ascii?Q?nL6wdQJAHiwC1a83AfHcqIB3gkbcven4tv+3UV/1/fTwFmlUHyZL4ooRp5eO?=
 =?us-ascii?Q?V4nD5RFFp1fgzxL4Iz0HWfeH?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb3a20ec-5da6-4e65-5367-08d945d44482
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 08:00:23.2967
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W4IVN55h+225aM6lDFS4tW3vZ4hiulF1gxzSK2AeNrPstk9osyCXuxF0nsfUXy+VW5iXqKKwPBIDpHq5UgoWVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB5676
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> From: Kimito Sakata <kimito.sakata@oracle.com>
>=20
> Added a local buffer to create a NULL terminated string to print the
> Firmware Version instead of attempting to print directly from
> ext_csd buffer. The last byte of the Firmware Version field may not
> be NULL and the next field may also not be which may cause it to
> print garbage.
>=20
> Tested on x86 platform.
Fixes: 89cd01ed865a (mmc_utils: add ffu support)

Signed-off-by: Kimito Sakata <kimito.sakata@oracle.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  mmc_cmds.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/mmc_cmds.c b/mmc_cmds.c
> index afa85b7..205e6e5 100644
> --- a/mmc_cmds.c
> +++ b/mmc_cmds.c
> @@ -1392,6 +1392,7 @@ int do_read_extcsd(int nargs, char **argv)
>         __u32 regl;
>         int fd, ret;
>         char *device;
> +       char lbuf[10];
>         const char *str;
>=20
>         if (nargs !=3D 2) {
> @@ -1833,8 +1834,9 @@ int do_read_extcsd(int nargs, char **argv)
>         }
>=20
>         if (ext_csd_rev >=3D 7) {
> -               printf("eMMC Firmware Version: %s\n",
> -                       (char*)&ext_csd[EXT_CSD_FIRMWARE_VERSION]);
> +                memset(lbuf, 0, sizeof(lbuf));
> +               strncpy(lbuf, (char*)&ext_csd[EXT_CSD_FIRMWARE_VERSION], =
8);
> +               printf("eMMC Firmware Version: %s\n", lbuf);
>                 printf("eMMC Life Time Estimation A
> [EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_A]: 0x%02x\n",
>                         ext_csd[EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_A]);
>                 printf("eMMC Life Time Estimation B
> [EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_B]: 0x%02x\n",
> --
> 2.31.1