Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Jul 2021 04:59:30 -0400 (EDT)
From:   Mikulas Patocka <mpatocka@redhat.com>
To:     Nico Schottelius <nico-linuxsetlocalversion@schottelius.org>
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] scripts/setlocalversion: fix a bug when LOCALVERSION
 is empty
In-Reply-To: <87tukzgrkg.fsf@ungleich.ch>
Message-ID: <alpine.LRH.2.02.2107130454430.3795@file01.intranet.prod.int.rdu2.redhat.com>
References: <alpine.LRH.2.02.2107120957300.14207@file01.intranet.prod.int.rdu2.redhat.com> <YOyGrUvA4LjydcP3@kroah.com> <alpine.LRH.2.02.2107121502380.8445@file01.intranet.prod.int.rdu2.redhat.com> <YOyVH3qD9O3qsNUL@kroah.com>
 <alpine.LRH.2.02.2107121528270.11724@file01.intranet.prod.int.rdu2.redhat.com> <87tukzgrkg.fsf@ungleich.ch>
User-Agent: Alpine 2.02 (LRH 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Precedence: bulk


On Mon, 12 Jul 2021, Nico Schottelius wrote:

> 
> Sorry to say, but I am not convinced by the patch.
> 
> While yes, we might have changed the behaviour slightly, reading
> something on the line of
> 
> if [ -z ... ]
> 
> is significantly more simple, elegant and easier to maintain, than
> a rather atypical special case for setting a variable to empty,
> using
> 
> if [ "${LOCALVERSION+set}" != "set" ] ..
> 
> *and* because it is so atypical, adding a long comment for it, too.
> 
> Additonally, -z should be correct if the variable *is* truly empty. I
> assume it actually isn't and contains whitespace, which is not the same
> as being set and empty.
> 
> Instead of re-adding complexity, could you consider changing the build
> flow so that LOCALVERSION is either unset or empty?
> 
> Nico

I set LOCALVERSION to an empty string (with "export LOCALVERSION="). This 
prevented the kernel from adding a "+" sign to the kernel version. Since 
the commit 042da426f8eb, it no longer works and the kernel adds a "+" sign 
if LOCALVERSION is set and empty.

If you don't like "if [ "${LOCALVERSION+set}" != "set" ]", then please 
provide some other way how to test if the variable is set.

Mikulas