Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] mm: remove pfn_valid_within() and
 CONFIG_HOLES_IN_ZONE
To:     Mike Rapoport <rppt@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mike Rapoport <rppt@linux.ibm.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
References: <20210713080035.7464-1-rppt@kernel.org>
 <20210713080035.7464-2-rppt@kernel.org>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
Message-ID: <7300dfe1-0c6a-ae2e-2c48-c885248ec263@redhat.com>
Date:   Tue, 13 Jul 2021 11:51:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210713080035.7464-2-rppt@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 13.07.21 10:00, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@linux.ibm.com>
> 
> After recent changes in freeing of the unused parts of the memory map and
> rework of pfn_valid() in arm and arm64 there are no architectures that can
> have holes in the memory map within a pageblock and so nothing can enable
> CONFIG_HOLES_IN_ZONE which guards non trivial implementation of
> pfn_valid_within().
> 
> With that, pfn_valid_within() is always hardwired to 1 and can be
> completely removed.
> 
> Remove calls to pfn_valid_within() and CONFIG_HOLES_IN_ZONE.
> 
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>

There is currently the discussion to increase MAX_ORDER, for example, to 
cover 1GiB instead of 4MiB on x86-64. This would mean that we could 
suddenly, again, have holes insides MAX_ORDER - 1 pages.

So I assume if we ever go down that path, we'll need something like this 
again.

For now, this looks like the right thing to do

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb