Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3770936pxv; Tue, 13 Jul 2021 03:24:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYzlANG8LGatXzaLhtJIyb+S6vmSSfGXtHaG6aQNMxFnoISucsiVFHgysyFdYcFQ5mCSvJ X-Received: by 2002:a92:d9ce:: with SMTP id n14mr2378293ilq.29.1626171877032; Tue, 13 Jul 2021 03:24:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626171877; cv=none; d=google.com; s=arc-20160816; b=e3Yhbk6RMQcPPaibQr39pIUpXSyt3Xuz/BC+6E9ZIqSliOre7+0QcRw4mZWdKsMgKF MU7ggvkr/be+8+udntnzuM/NxYWrlvH+AuO8clUntDx77pIMRudZAx6NqiB6cUMhLBT8 kOi/cQ1kqFLu/33YzUHIeF/wTmg3oV4ivDV/3hFg/CQ0NeS54b3ZRauTefUFhKq4opkh pboTkGQFEJjc5UNq0eu/kqNBkln26vwbEm6iQa7QAfsi/AvFJ6hZRWaDxDxSy8lzjYr+ +pQ3da4uRjXI9h2wB913LAneMLwtETu7B54qhl8xYQKYXNfF9phL8Ndn7hOojBJq9AU1 6LQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=4b0rMs1c+TnVJJYgXb1KNxag5Zuc5sNyuK7xfcazIVc=; b=rGEp71wqqznGJdWIHVZHzz0fXnscquUpV2Y6TZO4obx+TO7/DFo0OuFvN+zjJBeTY0 KL8IMtYy0m9KIqA7SI9t+SEYTetPyUkE7Y/sGa7kR0RcJcxPX4nEcYK++IGRrVD/svgk CCL3z8atNCHz/ThTPQvGXpy2SHfPtDCFSu1QMSKOXtMgtizRs/fLVafmtPftjnAfw0YV zZnR5BN7vqYsLhnJhB87I0Mg50YRP0Ju1NAc6A2astNlcziBO+PFQLk5Vsuhr9BB75gX ywZiYZGmbhOSeikeAaUe8i+DZAegDk+ifVCP9uSMASGmpJpiKo3cheW7VTqrq/igQhg1 FMew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j12si20654187jar.85.2021.07.13.03.24.23; Tue, 13 Jul 2021 03:24:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235326AbhGMK01 (ORCPT + 99 others); Tue, 13 Jul 2021 06:26:27 -0400 Received: from foss.arm.com ([217.140.110.172]:40110 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235143AbhGMK00 (ORCPT ); Tue, 13 Jul 2021 06:26:26 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 90C666D; Tue, 13 Jul 2021 03:23:36 -0700 (PDT) Received: from [10.57.36.240] (unknown [10.57.36.240]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 898223F7D8; Tue, 13 Jul 2021 03:23:34 -0700 (PDT) Subject: Re: [PATCH v2 1/2] dt-bindings: display: rockchip: Add compatible for rk3568 HDMI To: Benjamin Gaignard , hjc@rock-chips.com, heiko@sntech.de, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, algea.cao@rock-chips.com, andy.yan@rock-chips.com Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20210707120323.401785-1-benjamin.gaignard@collabora.com> <20210707120323.401785-2-benjamin.gaignard@collabora.com> From: Robin Murphy Message-ID: Date: Tue, 13 Jul 2021 11:23:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210707120323.401785-2-benjamin.gaignard@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-07-07 13:03, Benjamin Gaignard wrote: > Define a new compatible for rk3568 HDMI. > This version of HDMI hardware block needs two new clocks hclk_vio and hclk > to provide phy reference clocks. Do you know what hclk_vio is and whether it's actually necessary? I don't see any mention of it downstream, and based on previous experience I'm suspicious that it might be just the parent of hclk, and thus should not need to be explicitly claimed by the device or baked into it's binding. Robin. > Signed-off-by: Benjamin Gaignard > --- > version 2: > - Add the clocks needed for the phy. > > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > index 75cd9c686e985..cb8643b3a8b84 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml > @@ -23,6 +23,7 @@ properties: > - rockchip,rk3288-dw-hdmi > - rockchip,rk3328-dw-hdmi > - rockchip,rk3399-dw-hdmi > + - rockchip,rk3568-dw-hdmi > > reg-io-width: > const: 4 > @@ -51,8 +52,11 @@ properties: > - vpll > - enum: > - grf > + - hclk_vio > + - vpll > + - enum: > + - hclk > - vpll > - - const: vpll > > ddc-i2c-bus: > $ref: /schemas/types.yaml#/definitions/phandle >