Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3794730pxv; Tue, 13 Jul 2021 04:02:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCBmSRpb0MbJqy3PikszbopBm1AMOX4RUoBXETQInTw61l683WX4PPZffK0R2lGequZjBP X-Received: by 2002:a17:907:2d08:: with SMTP id gs8mr4956753ejc.224.1626174177294; Tue, 13 Jul 2021 04:02:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626174177; cv=none; d=google.com; s=arc-20160816; b=ErjQ1w+T9yUn4fSYUj3evId8dxuYDaR6E36qGLZtReOYn8wdXoQk1wjCrMdGCLTCGs Sa8Dtd3bJwbvN7ASyyiaOA4p6BDX78KbG7375rWim6KXEFbxXlYqJJfa47zbgEdUUKjo xNVTbel6/yMzktKN6LgEfaadErDl0WHOaCTNW21vzfD6U9ox+sG4fs5djs4V4eyHUAvv yMeywI9p46z0t0bX7nfc7uzhMyPjdP3B62yuL+85Q7hBQ/E+SbhjXgD9Zq7aqfsiABoK l5YqqEMAXXUdYpFnGjaYAPCcFfAHcKbhaPimjOVCnHf+idg8jeveQsZA5ZK0WgbtfPcO msYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=D9zpTdN6p7SwNXQB1vuqj99Xdu6Hr8oPzuitgbMbnZk=; b=ROLNFQJ1vdJb+9hn6ctqwstQxVYC+ZWsCKI6k14nKOzY4x8arnLaDHyKNgEDO278ST Sz4TUDpCHMtquUF16FL7GT5wXEfvCagzHWAucjloS30kKaWibJQDabJRxgz+hX0xJlAI qfQZR1K4+mX0mhxgllp7GP1481B9YqLPiHe+Sskv26k3a/3QB846SLDNIIPKTCXgTmTx h1c0/AYryIaPZ70ohE3lYNiMMS/PbYv2GPqWVPzmquDy8B2f3T7iqxFv40G1yT0fwdxp M/UF6eMNIW2HhPcx07f8o/ACmZL86q0CWzzuH48rvIRiiJrwSI2kOh3vMAbzmxD2T1b5 tYnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="ZTn/WbFD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l21si22283482edw.390.2021.07.13.04.02.34; Tue, 13 Jul 2021 04:02:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="ZTn/WbFD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235761AbhGMLBt (ORCPT + 99 others); Tue, 13 Jul 2021 07:01:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235390AbhGMLBt (ORCPT ); Tue, 13 Jul 2021 07:01:49 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42BA9C0613DD; Tue, 13 Jul 2021 03:58:59 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id v6so12342362lfp.6; Tue, 13 Jul 2021 03:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=D9zpTdN6p7SwNXQB1vuqj99Xdu6Hr8oPzuitgbMbnZk=; b=ZTn/WbFDqY9SPvf3lVVTkPfOrI5ttwO9SW0TSXDm2iFHdX8XB5zQ2x6G4XYT1UgUpg a3H+KqkJfkuVMp7uYIX22W7rEp/V06WBquLqI0hgEqBEbIfkkzz4XDNfv34OPNRNZEGn ZOK7klAN++kcFMvp2Kj52zf7rO57FcF6co/QtpeZYUdTF9l0WnjqXndAb/ORhNfoQKLH COAB5jL6JuLSEki7Un8IrS3SBUNqtPykbLHhfDM0g36cGC/X+DB75JdNtMgLjiEQ0ALX OmDvh/92srotT25b0RFy3APdl/KRPDP2sUPtLJMuVX6asw8DfDikuXAv8dFPLqAie7NS 9lIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=D9zpTdN6p7SwNXQB1vuqj99Xdu6Hr8oPzuitgbMbnZk=; b=iYJ+fjK7a+p/t6dLo1d/jLQLAVfmUvLEu7EU8Mj3/a7A00BZ23mqcUh9SUTvJVe/kV nWwMUL6NNwYYqinx2NlSlHotpXVp2QV7Gj9qaTO5EsbUy6xEImVxmvUi5XmbtG2GdCzo cVN3eUJnBxDw5dxVNr/ZdwrxIKZ6565ea6Ea3YPAyrQzsDBGqIzuXWmrcbA5huMKXWeU KNUesNu6rIlh75hDLZFRGzBdPUKp4E6ESnipfFjlnJpRlf7ySpY1FyfhpnTIFjnpuIDu uHmJeRhXpdIZHFz80LwWSCP8KGUiv+zVwhf6Zj9oIPA+K40SkP4KUFh+wwp7zAdzXxOj wN4Q== X-Gm-Message-State: AOAM530Nt++gAQ1Uzji/ThU9GxOovvLT+oqFcwuTulxtPMUnNUEct9ub 0Jrg06ihRARSqQ3vQiBbhLtrV6VGubcnlw== X-Received: by 2002:a05:6512:230d:: with SMTP id o13mr2900964lfu.557.1626173937603; Tue, 13 Jul 2021 03:58:57 -0700 (PDT) Received: from localhost.localdomain ([94.103.229.115]) by smtp.gmail.com with ESMTPSA id i67sm208006lji.60.2021.07.13.03.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 03:58:57 -0700 (PDT) From: Pavel Skripkin To: macro@orcam.me.uk, davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Skripkin Subject: [PATCH] net: fddi: fix UAF in fza_probe Date: Tue, 13 Jul 2021 13:58:53 +0300 Message-Id: <20210713105853.8979-1-paskripkin@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fp is netdev private data and it cannot be used after free_netdev() call. Using fp after free_netdev() can cause UAF bug. Fix it by moving free_netdev() after error message. Fixes: 61414f5ec983 ("FDDI: defza: Add support for DEC FDDIcontroller 700 TURBOchannel adapter") Signed-off-by: Pavel Skripkin --- drivers/net/fddi/defza.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/fddi/defza.c b/drivers/net/fddi/defza.c index 14f07050b6b1..0de2c4552f5e 100644 --- a/drivers/net/fddi/defza.c +++ b/drivers/net/fddi/defza.c @@ -1504,9 +1504,8 @@ static int fza_probe(struct device *bdev) release_mem_region(start, len); err_out_kfree: - free_netdev(dev); - pr_err("%s: initialization failure, aborting!\n", fp->name); + free_netdev(dev); return ret; } -- 2.32.0