Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3845911pxv; Tue, 13 Jul 2021 05:17:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwP63CL2iDbz/BDdQbtZz82KwTQKPGYNY8ymw7mbadHrDYfSqowpyEL8BhgeNQDpeigdhBf X-Received: by 2002:a17:906:81da:: with SMTP id e26mr5428735ejx.352.1626178642854; Tue, 13 Jul 2021 05:17:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626178642; cv=none; d=google.com; s=arc-20160816; b=agKp/l9sGO7qC7oQWuTEg7IDa6UqagNwVEuOt7/EV247lxpsUuj+vAWsfke7sLz1Ub RFfUoFnmb/UWa+cS6ztZmX0DoOddmEkUGjjiwu/0fW6TIc1B/nxWbFL+4qJvg37893mB fzWBXwAriVi4WOYnRwdHS832c3Le3uexAqFwwgj2VDJwewXhraHbXYY0G2ctAWT5+wDo Nf4a/fkOBGVg5H+RoY8MJcugwAPfkeZbHdMEOpEdMOzRbeAoh4c42xQX3DYOpZlmRI+z V49t1+44MBbcndG8c7XSWnYztUhCNaA9B1sfjDKiX5anjEhDiICQ+uLSQA4wMTYLgCne ZgbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=A+K7ICpIJS2e3SylPpCA9Qv/+LkDj1PNqvZdF0fw5sY=; b=Xy0g/5GSaRnbERszax1BFw2aanyKjOAqrBSGmqn0FTsPxe7+ifRuzhhktH1NLOKVy/ iwt0pDRQUg5GMGHU00ZS+e0TJiSrpL3lg1mdBS/TwK7ocM6kAkCUiQA9WzVu+VfQ/Vo1 gOXdZF2Y6lX9f5cZBcoG7i9U/5Q3jiyuaSAqpevpw5AH4hMSL2CKabbW+mBKUfy9i2Bc vWl2F3vuFsuTtAQIJzYkolmFa/9ci1r11XRBdVGPoER1xxQuHe7f1Q0OXYJvAT+7mRdb pTrLNtsOV765dE2zGLZgVMHu4A19ZtCw0szfJsKV23allfb6YdnWlcfWcnrhQXHRO2Nk bhUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j6si2158079edt.334.2021.07.13.05.17.00; Tue, 13 Jul 2021 05:17:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236050AbhGMMRA (ORCPT + 99 others); Tue, 13 Jul 2021 08:17:00 -0400 Received: from outbound-smtp49.blacknight.com ([46.22.136.233]:45127 "EHLO outbound-smtp49.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235968AbhGMMRA (ORCPT ); Tue, 13 Jul 2021 08:17:00 -0400 Received: from mail.blacknight.com (pemlinmail06.blacknight.ie [81.17.255.152]) by outbound-smtp49.blacknight.com (Postfix) with ESMTPS id 96B35FAD85 for ; Tue, 13 Jul 2021 13:14:09 +0100 (IST) Received: (qmail 32481 invoked from network); 13 Jul 2021 12:14:09 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.255]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 13 Jul 2021 12:14:09 -0000 Date: Tue, 13 Jul 2021 13:14:08 +0100 From: Mel Gorman To: "Xu, Yanfei" Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/page_alloc: correct return value when failing at preparing Message-ID: <20210713121408.GC3809@techsingularity.net> References: <20210709102855.55058-1-yanfei.xu@windriver.com> <20210709122225.GZ3840@techsingularity.net> <98c83852-6745-bf57-2415-696edea89704@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <98c83852-6745-bf57-2415-696edea89704@windriver.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 10, 2021 at 02:58:02PM +0800, Xu, Yanfei wrote: > > > On 7/9/21 8:22 PM, Mel Gorman wrote: > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > On Fri, Jul 09, 2021 at 06:28:54PM +0800, Yanfei Xu wrote: > > > If the array passed in is already partially populated, we should > > > return "nr_populated" even failing at preparing arguments stage. > > > > > > Signed-off-by: Yanfei Xu > > > > ff4b2b4014cb ("mm/page_alloc: correct return value of populated elements if bulk array is populated") > > > > This is a different return location from you posted. > You're right, I'll pick this up and stage it with a series of patches that should have gone in during the merge window but were too late. Thanks. -- Mel Gorman SUSE Labs