From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "'Ingo Molnar'" <mingo@elte.hu>, "Mike Galbraith" <efault@gmx.de>
Cc: <nickpiggin@yahoo.com.au>, "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
       <linux-kernel@vger.kernel.org>, "Andrew Morton" <akpm@osdl.org>
Subject: RE: [rfc patch] Re: sched: incorrect argument used in task_hot()
Date: Fri, 17 Nov 2006 11:41:51 -0800
Message-ID: <000401c70a80$6eaa61a0$2880030a@amr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AccKfjk9SR1RaxbuQlizu1cJKCob0gAAZD0A
In-Reply-To: <20061117192052.GA23272@elte.hu>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1380
Lines: 29

Ingo Molnar wrote on Friday, November 17, 2006 11:21 AM
> * Mike Galbraith <efault@gmx.de> wrote:
> 
> > One way to improve granularity, and eliminate the possibility of 
> > p->last_run being > rq->timestamp_tast_tick, and thereby short 
> > circuiting the evaluation of cache_hot_time, is to cache the last 
> > return of sched_clock() at both tick and sched times, and use that 
> > value as our reference instead of the absolute time of the tick.  It 
> > won't totally eliminate skew, but it moves the reference point closer 
> > to the current time on the remote cpu.
> > 
> > Looking for a good place to do this, I chose update_cpu_clock().
> 
> looks good to me - thus we will update the timestamp not only in the 
> timer tick, but also upon every context-switch (when we acquire 
> sched_clock() value anyway). Lets try this in -mm?

Certainly gets my vote.  For my particular workload environment, there
are enough schedule activity on the remote CPU and in theory it should
make time calculation a lot better than what it is now.  I will run a
couple of experiment to verify.

Acked-by: Ken Chen <kenneth.w.chen@intel.com>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/