Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Jul 2021 15:06:56 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Martin Schiller <ms@dev.tdt.de>
Cc:     Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Hauke Mehrtens <hauke@hauke-m.de>, f.fainelli@gmail.com,
        hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] net: phy: intel-xway: Add RGMII internal
 delay configuration
Message-ID: <YO2P8J4Ln+RwxkfO@lunn.ch>
References: <20210709164216.18561-1-ms@dev.tdt.de>
 <CAFBinCCw9+oCV==1DrNFU6Lu02h3OyZu9wM=78RKGMCZU6ObEA@mail.gmail.com>
 <fcb3203ea82d1180a6e471f22e39e817@dev.tdt.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fcb3203ea82d1180a6e471f22e39e817@dev.tdt.de>
Precedence: bulk

> > [...]
> > > +#if IS_ENABLED(CONFIG_OF_MDIO)
> > is there any particular reason why we need to guard this with
> > CONFIG_OF_MDIO?
> > The dp83822 driver does not use this #if either (as far as I
> > understand at least)
> > 
> 
> It makes no sense to retrieve properties from the device tree if we are
> compiling for a target that does not support a device tree.
> At least that is my understanding of this condition.

There should be stubs for all these functions, so if OF is not part of
the configured kernel, stub functions take their place. That has the
advantage of at least compiling the code, so checking parameter types
etc. We try to avoid #ifdef where possible, so we get better compiler
build test coverage. The more #ifef there are, the more different
configurations that need compiling in order to get build coverage.

	       Andrew