Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Jul 2021 09:09:04 -0400 (EDT)
From:   Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To:     paulmck <paulmck@kernel.org>
Cc:     zhouzhouyi@gmail.com, Josh Triplett <josh@joshtriplett.org>,
        rostedt <rostedt@goodmis.org>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        "Joel Fernandes, Google" <joel@joelfernandes.org>,
        rcu <rcu@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Message-ID: <520385500.15226.1626181744332.JavaMail.zimbra@efficios.com>
In-Reply-To: <20210713041607.GU4397@paulmck-ThinkPad-P17-Gen-1>
References: <20210713005645.8565-1-zhouzhouyi@gmail.com> <20210713041607.GU4397@paulmck-ThinkPad-P17-Gen-1>
Subject: Re: [PATCH] RCU: Fix macro name CONFIG_TASKS_RCU_TRACE
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Thread-Topic: Fix macro name CONFIG_TASKS_RCU_TRACE
Thread-Index: ROUS2UuRwOuQB1BTugtLk1BJzQIfiw==
Precedence: bulk

----- On Jul 13, 2021, at 12:16 AM, paulmck paulmck@kernel.org wrote:

> On Tue, Jul 13, 2021 at 08:56:45AM +0800, zhouzhouyi@gmail.com wrote:
>> From: Zhouyi Zhou <zhouzhouyi@gmail.com>
>> 
>> Hi Paul,
>> 
>> During my studying of RCU, I did a grep in the kernel source tree.
>> I found there are 3 places where the macro name CONFIG_TASKS_RCU_TRACE
>> should be CONFIG_TASKS_TRACE_RCU instead.
>> 
>> Without memory fencing, the idle/userspace task inspection may not
>> be so accurate.
>> 
>> Thanks for your constant encouragement for my studying.
>> 
>> Best Wishes
>> Zhouyi
>> 
>> Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
> 
> Good eyes, and those could cause real bugs, so thank you!

Hi Paul,

This makes me wonder: what is missing testing-wise in rcutorture to
catch those issues with testing before they reach mainline ?

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com