Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] tools: PCI: Zero-initialize param
To:     Leon Romanovsky <leon@kernel.org>
Cc:     bhelgaas@google.com, kishon@ti.com, lorenzo.pieralisi@arm.com,
        kw@linux.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210627003937.6249-1-yang.shunyong@gmail.com>
 <d4c250af-aa50-0ec0-c66a-104092646e15@gmail.com> <YOrcUcx2PdaBxRQi@unreal>
From:   Shunyong Yang <yang.shunyong@gmail.com>
Message-ID: <26dbd10a-3d4e-032a-ec56-3eddac5eb4aa@gmail.com>
Date:   Tue, 13 Jul 2021 21:24:55 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YOrcUcx2PdaBxRQi@unreal>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,  Romanovsky,

On 2021/7/11 19:56, Leon Romanovsky wrote:
> On Sun, Jul 11, 2021 at 09:48:17AM +0800, Shunyong Yang wrote:
>> Hi, Bjorn and Kishon,
>>
>>    Gentle ping. Would you please help to review and merge this tiny change?
>>
>> Thansk.
>>
>> Shunyong.
>>
>> On 2021/6/27 8:39, Shunyong Yang wrote:
>>> The values in param may be random if they are not initialized, which
>>> may cause use_dma flag set even when "-d" option is not provided
>>> in command line. Initializing all members to 0 to solve this.
>>>
>>> Signed-off-by: Shunyong Yang <yang.shunyong@gmail.com>
>>> ---
>>>    tools/pci/pcitest.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
>>> index 0a1344c45213..59bcd6220a58 100644
>>> --- a/tools/pci/pcitest.c
>>> +++ b/tools/pci/pcitest.c
>>> @@ -40,7 +40,7 @@ struct pci_test {
>>>    static int run_test(struct pci_test *test)
>>>    {
>>> -	struct pci_endpoint_test_xfer_param param;
>>> +	struct pci_endpoint_test_xfer_param param = {0};
> You can simply write {} instead of {0} - zero is not needed.
>
> Thanks

    Will change as you said.

Thanks.

Shunyong.

>>>    	int ret = -EINVAL;
>>>    	int fd;