Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Jul 2021 14:34:11 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     Michal Hocko <mhocko@suse.com>, akpm@linux-foundation.org,
        hannes@cmpxchg.org, vbabka@suse.cz, axboe@kernel.dk,
        iamjoonsoo.kim@lge.com, alexs@kernel.org, apopple@nvidia.com,
        minchan@kernel.org, david@redhat.com, shli@fb.com,
        hillf.zj@alibaba-inc.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] mm/vmscan: put the redirtied MADV_FREE pages back to
 anonymous LRU list
Message-ID: <YO2WUx0a5go71Vhm@casper.infradead.org>
References: <20210710100329.49174-1-linmiaohe@huawei.com>
 <20210710100329.49174-2-linmiaohe@huawei.com>
 <YOvtmy9ggJA4KUIQ@dhcp22.suse.cz>
 <9409189e-44f7-2608-68af-851629b6d453@huawei.com>
 <YO1dGvcTLaRJplRQ@dhcp22.suse.cz>
 <ec86d902-1da5-2f49-7324-a796d32ac979@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ec86d902-1da5-2f49-7324-a796d32ac979@huawei.com>
Precedence: bulk

On Tue, Jul 13, 2021 at 09:13:51PM +0800, Miaohe Lin wrote:
> >> When the MADV_FREE pages are redirtied before they could be reclaimed, the pages
> >> should be put back to anonymous LRU list by setting SwapBacked flag, thus the
> >> pages will be reclaimed in normal swapout way.
> > 
> > Agreed. But the question is why this needs an explicit handling here
> > when we already do handle this case when trying to unmap the page.
> 
> This makes me think more. It seems even the page_ref_freeze call is guaranteed to
> success as no one can grab the page refcnt after the page is successfully unmapped.

NO!  This is wrong.  Every page can have its refcount speculatively raised
(and then lowered).  The two prime candidates for this are lockless GUP
and page cache lookups, but there can be others too.