Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Mel Gorman <mgorman@techsingularity.net>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>,
        Zhang Qiang <Qiang.Zhang@windriver.com>,
        Yanfei Xu <yanfei.xu@windriver.com>,
        Jesper Dangaard Brouer <brouer@redhat.com>,
        Matteo Croce <mcroce@microsoft.com>,
        Linux-MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] mm/page_alloc: correct return value when failing at
 preparing
Thread-Topic: [PATCH 2/4] mm/page_alloc: correct return value when failing at
 preparing
Thread-Index: AQHXd+7xOOwL13NwHEq2099ClUljlKtA9QGA
Date:   Tue, 13 Jul 2021 14:21:58 +0000
Message-ID: <E7C50307-24D8-4D75-B65E-0D7CA7C08048@oracle.com>
References: <20210713135625.7615-1-mgorman@techsingularity.net>
 <20210713135625.7615-3-mgorman@techsingularity.net>
In-Reply-To: <20210713135625.7615-3-mgorman@techsingularity.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vQNzZbhQU/2KmyStpDFsrjwEMEEzwheOC0WnD7Ba87VKN4fkSeNF0KM+013T?=
 =?us-ascii?Q?vKKDAs3FApGR/zCHaXPcw86dme1PX0tYvCHJoyi2bBDz8ZE7t5m1El9zQeFB?=
 =?us-ascii?Q?f3vvlySuAfgb3VTCdXkrd5PY4t+uupNqqoUgL0Q5i3aHo8X4wnYOYX/G/wvU?=
 =?us-ascii?Q?aDNQXIcRa6jizS21rjfEZ0BY3tvBLK2vutH0utNZzmR3QCl36+ZXVAdY9dOG?=
 =?us-ascii?Q?l7Sgciyny0g1D8mNmGgm4JIB+9wUPvkfGkRdj2L4fo2juapGsMGpa+WI6tOz?=
 =?us-ascii?Q?VTKwgkwcXYaV9bEY/UdDUyM8ICmxoG+b+xLxA0AXOUmiHjc6adDidf+2brlL?=
 =?us-ascii?Q?8PSqTRXUmUBxHQ1bLFlxdlRVnHe8asVDz2KT8UavgOKVbuEB6/s72FWyN9UE?=
 =?us-ascii?Q?eTeMe9FI0qYgaoXnML10JujAVWS+9HR2TDFzp4eh+INQ4MTu+sdUuD+SwQJ4?=
 =?us-ascii?Q?y7YJm6MafxGYlGaU+vzZqjteRN1kaYxZ+UhhNijP59GSj5aY3OxDnnRHk/av?=
 =?us-ascii?Q?MwDmRh6q9NpxqAs3aTPUPq/K3xb+aF2RFXNhgU2RxH8Pn50EIy6leUBJwE6/?=
 =?us-ascii?Q?iezy76Umzu4sRj7K3q5rmLKPLPzED92fol2TvFQV2QROdGLjo9yvw+Pq1GYh?=
 =?us-ascii?Q?nxqXpFh/pYASqkUUkTL5W0gnUTTOwBKWca+mhG5QGOONdZvNVPfll4pu6QXR?=
 =?us-ascii?Q?Yej/OX2l8tXZjXJnT0rNGbyZKHSUwD5umzUdqLQHdmZ2i/wbzK3zxZBfS8hb?=
 =?us-ascii?Q?0HoVv60dj3sCIxa9qgO6yh7pUWDMZfR+/quxY6mdTL4fEqgp1q2qIhxEgd/z?=
 =?us-ascii?Q?Tgu856U+kcexFdjY8UULiAaujG539juTVn2y060CH7Zh4Xwoq8OCdL/h8ybl?=
 =?us-ascii?Q?uCrjMdP/YsGL9ZLBA9EsBmHU1Hjzh3eSvza8xbaJuGFst7kdXggRgD04BcLR?=
 =?us-ascii?Q?l64Guk2dT/CcjnWetiVIm/dWbUhVS66HX055sfleTu7j5qJeuJztH+ZaHdL3?=
 =?us-ascii?Q?FL2z6AfVTfNdNQJ6DNOOvdNjYdipavRX9t14xJ21gdKryB7sgXKWOqNhbQu2?=
 =?us-ascii?Q?/w7N/vij4fYGFZShagwKocwvhuxnGJsrkRgwcIhNGKxvj1wzwTqCnCW+ddQq?=
 =?us-ascii?Q?vnrWmIpEx+GnTwI9LgwlpD4MAJPcwReH9Ax02yGixdOySOwcbAnUVKFlpT8g?=
 =?us-ascii?Q?ybDJWgzfEPKybLktnr/i7X3CPpavVlf/H8GhVUn46uEWTLNUUkIgrhqsaz8Y?=
 =?us-ascii?Q?WUvOA7blnEWqomUIgVOZ5iw96DSM9Hwgo5BTQiJGBEzkmLhCyvEKq2gOzeo7?=
 =?us-ascii?Q?0IaY35+ExdMoTOtXlZcY9knN?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F434093B0E30D94C97F6F43BAAF4A65E@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86e796b5-6f2b-4aca-1b68-08d946099304
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 14:21:58.2933
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HlCbNiSBlzBVZ8/6ZgRFLUDXaZKpDnsEMYzUj3bRukEUbrzw+dd0wBsnITJQs5XwJgEz9sUMPtxxwtWTCnXaEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4259
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10043 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 phishscore=0 adultscore=0 mlxlogscore=943 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2107130092
X-Proofpoint-ORIG-GUID: MTaGNB5zhBmbhG36pjrJtYkTZMRZJNy3
X-Proofpoint-GUID: MTaGNB5zhBmbhG36pjrJtYkTZMRZJNy3
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jul 13, 2021, at 9:56 AM, Mel Gorman <mgorman@techsingularity.net> wro=
te:
>=20
> From: Yanfei Xu <yanfei.xu@windriver.com>
>=20
> If the array passed in is already partially populated, we should
> return "nr_populated" even failing at preparing arguments stage.
>=20
> Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
> Link: https://lore.kernel.org/r/20210709102855.55058-1-yanfei.xu@windrive=
r.com
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 6ef86f338151..803414ce9264 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5255,7 +5255,7 @@ unsigned long __alloc_pages_bulk(gfp_t gfp, int pre=
ferred_nid,
> 	gfp &=3D gfp_allowed_mask;
> 	alloc_gfp =3D gfp;
> 	if (!prepare_alloc_pages(gfp, 0, preferred_nid, nodemask, &ac, &alloc_gf=
p, &alloc_flags))
> -		return 0;
> +		return nr_populated;

Can you restore the hunk in patch 3/4 that changes this "return nr_populate=
d;"
to "goto out;" ?


> 	gfp =3D alloc_gfp;
>=20
> 	/* Find an allowed local zone that meets the low watermark. */
> --=20
> 2.26.2
>=20

--
Chuck Lever