Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Mel Gorman <mgorman@techsingularity.net>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Desmond Cheong Zhi Xi <desmondcheongzx@gmail.com>,
        Zhang Qiang <Qiang.Zhang@windriver.com>,
        Yanfei Xu <yanfei.xu@windriver.com>,
        Jesper Dangaard Brouer <brouer@redhat.com>,
        Matteo Croce <mcroce@microsoft.com>,
        Linux-MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] mm/page_alloc: correct return value when failing at
 preparing
Thread-Topic: [PATCH 2/4] mm/page_alloc: correct return value when failing at
 preparing
Thread-Index: AQHXd+7xOOwL13NwHEq2099ClUljlKtA9QGAgAAJn4CAAAFlgA==
Date:   Tue, 13 Jul 2021 15:01:24 +0000
Message-ID: <38D7DF36-4425-4D8B-9091-CE49CE046D6A@oracle.com>
References: <20210713135625.7615-1-mgorman@techsingularity.net>
 <20210713135625.7615-3-mgorman@techsingularity.net>
 <E7C50307-24D8-4D75-B65E-0D7CA7C08048@oracle.com>
 <20210713145623.GE3809@techsingularity.net>
In-Reply-To: <20210713145623.GE3809@techsingularity.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KhJnkzvgeBiHZS7M8rjIvCP07kyCEKyQWkjhGb1X3CzgnJUHj3wWgmBwCUhq?=
 =?us-ascii?Q?JXuA8GnhJMb+FEGKhLyuSL8UJUQXScWn281RHZ5ty2V3d6ZziY5hwTriIu+n?=
 =?us-ascii?Q?kLZ8Tm+UTl5ua7/RLrEWdJJS38BJRN6KTyCtu1YvS6k8PO8EyoXclXnOfmQK?=
 =?us-ascii?Q?mDmN9yGWG++6GfTXhsVQvWfEMtidHcma6yJIBettyi5dT/bAOPNP8J1WO8X1?=
 =?us-ascii?Q?dmO7VOpaGR/rT3NL1jYzetSpIdZddZegsQkYa+ICFXOiNah/WXlaoFCe8TPk?=
 =?us-ascii?Q?5FUCybGVxuuAIMc5vH5E6c08OZZJEGJN8CJU6Guauo+tHrbwUbxEz9NjQ/4H?=
 =?us-ascii?Q?eIqpl6ONoNZTY3HiTDAvDgSP+Szal188pM9TA1eDpD8c6puhZrCa+VhUc+hv?=
 =?us-ascii?Q?NWzTmPWQVOvZ/GT5xr5nevO20xw+i9LQw1x/JOfivd46KqrexUg3rO955adN?=
 =?us-ascii?Q?1d7qop/q9ZLZwI/93s0GG31ZE5hlpYoaimEIvPO1n5kJvmd96BQCh02pKYPu?=
 =?us-ascii?Q?waoy0gnaJzO/VHeC6TJGIk3DYKmNJs76+qsiIxJ1u/iLsvjQf1ML8Yw7crRX?=
 =?us-ascii?Q?QB47o5tpln+J05tQY8XUDITiU9ioGXTpGc4DUhxINghfg+inwjSHgNl+reLj?=
 =?us-ascii?Q?EdX823/JJfCp6bFtS7vOfpA12MHLL6BDiJ7B+moxWrUPgbst+vU5OnkSxANp?=
 =?us-ascii?Q?oXZnRluL8oJGF82/GsBTu0YaDnoQ/gpGyFv0lXE/7DsI9WxIpNE8KuxeenfX?=
 =?us-ascii?Q?1RjlCGL3gsZ5CoL7uPuQLiSIJowkKuuSS+oUCz6XavtVAeGzl/NDbYpXgBJv?=
 =?us-ascii?Q?h/vBlV6x/cxE3C6JDTMzSBRUeZfi8ZkxwxiklOhO0XfGycjw+eju7BOlzFZe?=
 =?us-ascii?Q?eLOoVUVXweMilT4Zrko09u6GmPK83L0Bzdi5PZHg09KJsp+bPJcBd6c338kp?=
 =?us-ascii?Q?Or/DMvwwof1HagvuE6eUESBHGMcCnrfYNEMqPcYHiL+k9yfsp2PwOSyhbYAt?=
 =?us-ascii?Q?Hu/dQ0K1nTaSBnhgWS1ZbV//+imZVekCzvGPYWORcP8zB9m1wwqpuooBRhKw?=
 =?us-ascii?Q?vvUB8sz6bLNaigFf9Q6OdKxNTLVbaOAMwn2lcfvHnCna46y/VxFIUWCFIOB2?=
 =?us-ascii?Q?SMNQPjJfPY5yT26tvFx1H1B82IlGt6WH7dtcRBSlM0XsF+KL0mftLld6mB0D?=
 =?us-ascii?Q?Zx2F6zShpvvZxBzLXkZvpS0d7c0ES0+9PvgIR6lcVfiNey1O4PiDPwYLBN87?=
 =?us-ascii?Q?KtN7HLAYLJN5C8Nt1pct4VlXXrZQQ9NNBp6SvLKJYZtJ53S+elSL01TOF3Mu?=
 =?us-ascii?Q?9hispajXCdkThKd4EEpKLVTi?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B7F6EEC9EE51D64E900FCC0F2747DCC9@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4688.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cba6e9d-ce3e-4a74-b1d4-08d9460f1521
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 15:01:24.1434
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1F74ae8Bpfg0f/tAEyAaWgyI00SbCvtOEWvkJLiS/aVJi8Xg0abIzl9t9JMSe8BHhgoBhUC5xzVYv8rpYIxyaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2968
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10044 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 spamscore=0 suspectscore=0 adultscore=0 mlxlogscore=978 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2107130096
X-Proofpoint-ORIG-GUID: vmlvwYzqOGKvW5jx92ZJAFSkEDJo_mac
X-Proofpoint-GUID: vmlvwYzqOGKvW5jx92ZJAFSkEDJo_mac
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jul 13, 2021, at 10:56 AM, Mel Gorman <mgorman@techsingularity.net> wr=
ote:
>=20
> On Tue, Jul 13, 2021 at 02:21:58PM +0000, Chuck Lever III wrote:
>>=20
>>=20
>>> On Jul 13, 2021, at 9:56 AM, Mel Gorman <mgorman@techsingularity.net> w=
rote:
>>>=20
>>> From: Yanfei Xu <yanfei.xu@windriver.com>
>>>=20
>>> If the array passed in is already partially populated, we should
>>> return "nr_populated" even failing at preparing arguments stage.
>>>=20
>>> Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
>>> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
>>> Link: https://lore.kernel.org/r/20210709102855.55058-1-yanfei.xu@windri=
ver.com
>>> ---
>>> mm/page_alloc.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>=20
>>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>>> index 6ef86f338151..803414ce9264 100644
>>> --- a/mm/page_alloc.c
>>> +++ b/mm/page_alloc.c
>>> @@ -5255,7 +5255,7 @@ unsigned long __alloc_pages_bulk(gfp_t gfp, int p=
referred_nid,
>>> 	gfp &=3D gfp_allowed_mask;
>>> 	alloc_gfp =3D gfp;
>>> 	if (!prepare_alloc_pages(gfp, 0, preferred_nid, nodemask, &ac, &alloc_=
gfp, &alloc_flags))
>>> -		return 0;
>>> +		return nr_populated;
>>=20
>> Can you restore the hunk in patch 3/4 that changes this "return nr_popul=
ated;"
>> to "goto out;" ?
>>=20
>=20
> I fixed that up in the series I sent out. I applied this patch first
> then reconciled the collision with your patch.

3/4 still needs to change this "return nr_populated;" to "goto out;"
as part of the clean up.


--
Chuck Lever