Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210708122447.3880803-1-sumit.garg@linaro.org>
 <CAD=FV=UhL32e7spQjr38Lwng0D7mUK+R7iGnmBah=tXzzXsO5g@mail.gmail.com>
 <CAFA6WYN4gMv9Hkuq=3v_UKg+Y1OvFfbOqgZxt7yGSd2RnVBdJw@mail.gmail.com>
 <CAD=FV=X9w_eY9cSkJLsF57bqL=FQFNcybG+P6tYT5mWTnG3TJA@mail.gmail.com> <20210713151032.hvsbufswijxt6uxk@maple.lan>
In-Reply-To: <20210713151032.hvsbufswijxt6uxk@maple.lan>
From:   Doug Anderson <dianders@chromium.org>
Date:   Tue, 13 Jul 2021 08:12:30 -0700
Message-ID: <CAD=FV=Wb_utQLP+U9Nv4=PUTdY49acRG03_Pxk31f4dR3673SQ@mail.gmail.com>
Subject: Re: [PATCH v3] kdb: Get rid of custom debug heap allocator
To:     Daniel Thompson <daniel.thompson@linaro.org>
Cc:     Sumit Garg <sumit.garg@linaro.org>,
        kgdb-bugreport@lists.sourceforge.net,
        Jason Wessel <jason.wessel@windriver.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Tue, Jul 13, 2021 at 8:10 AM Daniel Thompson
<daniel.thompson@linaro.org> wrote:
>
> On Tue, Jul 13, 2021 at 06:45:52AM -0700, Doug Anderson wrote:
> > Hi,
> >
> > On Tue, Jul 13, 2021 at 4:24 AM Sumit Garg <sumit.garg@linaro.org> wrote:
> > >
> > > > >  int kdbnearsym(unsigned long addr, kdb_symtab_t *symtab)
> > > > >  {
> > > > >         int ret = 0;
> > > > >         unsigned long symbolsize = 0;
> > > > >         unsigned long offset = 0;
> > > > > -#define knt1_size 128          /* must be >= kallsyms table size */
> > > > > -       char *knt1 = NULL;
> > > > > +       static char namebuf[KSYM_NAME_LEN];
> > > >
> > > > I guess this also ends up fixing a bug too, right? My greps show that
> > > > "KSYM_NAME_LEN" is 512
> > >
> > > I can see "KSYM_NAME_LEN" defined as 128 here [1]. Are you looking at
> > > any other header file?
> > >
> > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/kallsyms.h#n18
> >
> > Ah ha, it's recent! See commit f2f6175186f4 ("kallsyms: increase
> > maximum kernel symbol length to 512")
>
> Ineed. So recent that I think it hasn't been merged to mainline yet!
>
> This patch is part of the rust patch set. IIUC it is in linux-next for
> wider testing but I'd be surprised if it gets merged to mainline anytime
> soon (and even more amazed if it is merged without being rebased and
> given a new hash value ;-) ).

Ah, good point. Yeah, I should have mentioned that I was looking at
linuxnext. I guess maybe the right compromise is just to mention that
we'll be more robust in case that other #define changes. ;-)

-Doug