Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp3998882pxv; Tue, 13 Jul 2021 08:33:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwCehrLjGOyfBkjEpkIMohV3HBRSwI/OPOW1RDNs/4+LGr0Au9atsZTSel91pTWmWqTGbRO X-Received: by 2002:a17:907:72c9:: with SMTP id du9mr6278207ejc.497.1626190413907; Tue, 13 Jul 2021 08:33:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626190413; cv=none; d=google.com; s=arc-20160816; b=kfYVwItQKghM3KjHd9mE8mUjA1XxNtDHfcZLEWRRWVMD3j1IjZJ2NjloI47EFp1vrC RAevgXG5yvS3jkRedkIx6ox8PBFPYVjEBFzpSNh2rIwGWthGzlBWacSNQRv+yBOi3qLz GaFmPhzuhyg95QBiiMWZMxI5kcIlLFbq49YbooC35xMlYegeT2PBRYw3T5zUw1qbmuep LhjYrOPqgK71+36IXWV68foeZKyCTDwZmkuc/kVMKJRpjkObJufwy+HctVCFA4rA/BQq jy09A7haN709NaeTCLfvShvsWhmgz+asdkxyC0gm6IhM8dL+ItyXUmTzCOMk7ZmcPbBa pTyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :dlp-version:dlp-reaction:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=AlSPZe4GlYPrTo1PDHwvJ4MVIYGlaKxKPYvfE0vw5NI=; b=lkTPSdwsetFBgEdvCm14mHHYIACXBHJXjNknpDIl6WkHUrpxwVMq/HPXqcMLymRCiK LjQi8wlCF8inzEXNz75L3badlnTdNhM4dVge77h2q6ui6Sss+35S4JIlZcE0cG8ncmVt CNAOg8xYAtl2o0a5B8arBZ6WrhieOYdqxSgefGPYFDxnn5m93O5p58zRmmIknhGIvZv7 kiQD2xDS1+6/2pB9ILAw/6Br4RiO2BAkqM3PaIHqFdBAlEogZ7GWPX49yHuZk/edpZuU iOm/7cTHBRJKDwjJMgi0nW3AuhFwbMjTWsnmYgc2UrOcgjeFU6rlBPpharrlHkKtKd8A L2ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id du7si2244322ejc.188.2021.07.13.08.33.09; Tue, 13 Jul 2021 08:33:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237070AbhGMPdb convert rfc822-to-8bit (ORCPT + 99 others); Tue, 13 Jul 2021 11:33:31 -0400 Received: from mga07.intel.com ([134.134.136.100]:51843 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236992AbhGMPda (ORCPT ); Tue, 13 Jul 2021 11:33:30 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10044"; a="274015979" X-IronPort-AV: E=Sophos;i="5.84,236,1620716400"; d="scan'208";a="274015979" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 08:27:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,236,1620716400"; d="scan'208";a="503184746" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 13 Jul 2021 08:27:02 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 13 Jul 2021 08:27:01 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 13 Jul 2021 08:27:01 -0700 Received: from fmsmsx610.amr.corp.intel.com ([10.18.126.90]) by fmsmsx610.amr.corp.intel.com ([10.18.126.90]) with mapi id 15.01.2242.010; Tue, 13 Jul 2021 08:27:01 -0700 From: "Luck, Tony" To: Dwaipayan Ray , "yazen.ghannam@amd.com" , "bp@alien8.de" , "mchehab@kernel.org" , "james.morse@arm.com" , "rric@kernel.org" CC: "lukas.bulwahn@gmail.com" , "kbuild-all@lists.01.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3] EDAC/amd64: Use DEVICE_ATTR helper macros Thread-Topic: [PATCH v3] EDAC/amd64: Use DEVICE_ATTR helper macros Thread-Index: AQHXd7OeuAHraXCsaUyi/VM2AGH0MqtBByhQ Date: Tue, 13 Jul 2021 15:27:01 +0000 Message-ID: <43f0eb92643a4613992714effefed757@intel.com> References: <20210713065130.2151-1-dwaipayanray1@gmail.com> In-Reply-To: <20210713065130.2151-1-dwaipayanray1@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Instead of "open coding" DEVICE_ATTR, use the corresponding > helper macros DEVICE_ATTR_{RW,RO,WO} in amd64_edac.c > > Some function names needed to be changed to match the device > conventions _show and _store, but the functionality > itself is unchanged. > > The devices using EDAC_DCT_ATTR_SHOW() are left unchanged. > > Reviewed-by: Yazen Ghannam > Signed-off-by: Dwaipayan Ray Yazen, Boris is on vacation. Should I queue this change? -Tony