Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp4019092pxv; Tue, 13 Jul 2021 08:57:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1qvvumjGGmA2GJiRZusfQYby4KvWikGPIua1PJK9KTsp5j+Lfdea21H+0VhU7XvInIFNb X-Received: by 2002:a50:cb8b:: with SMTP id k11mr6693870edi.55.1626191852720; Tue, 13 Jul 2021 08:57:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626191852; cv=none; d=google.com; s=arc-20160816; b=O542hKiHwPkTey/ty30n7OfJinEFjyksZ8mT4aUhS476oEpg/anG4KB5wEIJkZ6abm TjcjQm0jvQIADQDgQcB3XecjAK2wuF/sbI+lHCupGB3i0OP2A2nmFc5SpHyAFHnX5tpZ mcj+wT5/Ygz0mLULmlRxwwKKgV5TZHFyUMNWkxyF1teqgrpRCbG9DN3bh9BBmOq01fjU 3bIz5XZ4AkYKaeUB0RGex2QKzBUJKcpC+ANfL3RWx7cS+oPA666OttwfB+JcLAoc33uR ymfcdS36lhr/oQCe9EFd5y+WvsdaDg9kSu0BTIcTHB412ozYb6j5wFIDCnUwQWK/slSu kWIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dmarc-filter:sender:dkim-signature; bh=QT0rCAMjsSGPZ3jKRP4o9QdSlxRce5w6tIBucvgc3v4=; b=PlqOQYXfzAYaXUkqJf9XITEH4YiIss2iEJKsBjW9RxhYiGaVQvL/tHaussp4ainsP+ odbbg/pq+eqxBOT1s6S3vbyM+AjOf+4ewfk/23Ac1jZbHvwmPU+LoL4q6eNtR7ZLjx4b M0oKriMzrl/0q/5UaoDWs9WxOzUZN63eNo8ZWBRSFbqYdz2+8a7vXwQbvZk8FXk8zEE2 Y1DwUNFdGdyNfh1RewrVix+ZI4WUemlA29A7LNStvJTmM4fD+geD47DDAXuL1Lq7NqR0 aOlZFz4cFb58BVvVRbcu9JUkSQMsfTfVBYAWy2ep1ur8/peCz5NJUszd8CeRAG2daFLC Y/0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=qDquTsOc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c23si489859eds.77.2021.07.13.08.57.06; Tue, 13 Jul 2021 08:57:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=qDquTsOc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237259AbhGMP6B (ORCPT + 99 others); Tue, 13 Jul 2021 11:58:01 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:48092 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237232AbhGMP56 (ORCPT ); Tue, 13 Jul 2021 11:57:58 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1626191708; h=References: In-Reply-To: Message-Id: Date: Subject: Cc: To: From: Sender; bh=QT0rCAMjsSGPZ3jKRP4o9QdSlxRce5w6tIBucvgc3v4=; b=qDquTsOczS4Si5H7ME6+cEeIXtECGDX1WyePJKGjWcYqfs0ExB7IMw+Hkt8ToM3kmeaKUd0K Wdd+wudKHePYGmoKQ1alOxZ2uA41qeV2VdQ7hKeEKhpK/+gpHfC75AM4vIDTeqAcfVSJqr2f HYdel50z4HJRUuj3ZU965PTtins= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 60edb74b01dd9a94313cf04a (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 13 Jul 2021 15:54:51 GMT Sender: khsieh=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A4FEBC43148; Tue, 13 Jul 2021 15:54:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from khsieh-linux1.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: khsieh) by smtp.codeaurora.org (Postfix) with ESMTPSA id 38621C433F1; Tue, 13 Jul 2021 15:54:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 38621C433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=khsieh@codeaurora.org From: Kuogee Hsieh To: dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org Cc: Kuogee Hsieh , abhinavk@codeaurora.org, aravindh@codeaurora.org, airlied@linux.ie, daniel@ffwll.ch, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/7] drm/msm/dp: return correct edid checksum after corrupted edid checksum read Date: Tue, 13 Jul 2021 08:54:05 -0700 Message-Id: <1626191647-13901-6-git-send-email-khsieh@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1626191647-13901-1-git-send-email-khsieh@codeaurora.org> References: <1626191647-13901-1-git-send-email-khsieh@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Response with correct edid checksum saved at connector after corrupted edid checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_panel.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index 88196f7..0fdb551 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.c +++ b/drivers/gpu/drm/msm/dp/dp_panel.c @@ -271,7 +271,7 @@ static u8 dp_panel_get_edid_checksum(struct edid *edid) { struct edid *last_block; u8 *raw_edid; - bool is_edid_corrupt; + bool is_edid_corrupt = false; if (!edid) { DRM_ERROR("invalid edid input\n"); @@ -303,7 +303,12 @@ void dp_panel_handle_sink_request(struct dp_panel *dp_panel) panel = container_of(dp_panel, struct dp_panel_private, dp_panel); if (panel->link->sink_request & DP_TEST_LINK_EDID_READ) { - u8 checksum = dp_panel_get_edid_checksum(dp_panel->edid); + u8 checksum; + + if (dp_panel->edid) + checksum = dp_panel_get_edid_checksum(dp_panel->edid); + else + checksum = dp_panel->connector->real_edid_checksum; dp_link_send_edid_checksum(panel->link, checksum); dp_link_send_test_response(panel->link); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project