Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Jul 2021 11:59:47 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Shirish S <shirish.s@amd.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ben Segall <bsegall@google.com>,
        "Mel Gorman" <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/debug: print column titles of show_state_filter()
Message-ID: <20210713115947.1c3bdbb8@oasis.local.home>
In-Reply-To: <20210713110518.52243-1-shirish.s@amd.com>
References: <20210713110518.52243-1-shirish.s@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 13 Jul 2021 16:35:18 +0530
Shirish S <shirish.s@amd.com> wrote:

> This addition in the debug output shall improve readablitly..
> Its not intuitive for users that the pid printed in last column
> is of parent process.
> 
> Signed-off-by: Shirish S <shirish.s@amd.com>
> ---
>  kernel/sched/core.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 2d9ff40f4661..d95d46a89e7e 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -8194,6 +8194,11 @@ void show_state_filter(unsigned int state_filter)
>  {
>  	struct task_struct *g, *p;
>  
> +#if BITS_PER_LONG == 32
> +	pr_info("  task                PC stack   pid father\n");
> +#else
> +	pr_info("  task                        PC stack   pid father\n");
> +#endif

Or remove the ugly #ifdef logic and just have:

	pr_info("  task%*s", BITS_PER_LONG == 32 ? 38 : 46,
		"PC stack   pid father\n");

-- Steve

>  	rcu_read_lock();
>  	for_each_process_thread(g, p) {
>  		/*