Received: by 2002:a9a:4c47:0:b029:116:c383:538 with SMTP id u7csp778891lko; Tue, 13 Jul 2021 10:01:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwa/Tnvbwaj/Mrtbu5tg+nQaJJhY1Jz2vrPnoD3vVIUQ7pwj6CuS41Ml08i6bz08E6rcwgN X-Received: by 2002:a17:906:69d7:: with SMTP id g23mr6659984ejs.195.1626195679008; Tue, 13 Jul 2021 10:01:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626195679; cv=none; d=google.com; s=arc-20160816; b=ZqL3KpCy6epyqkRRr7cyRgZuK2Q5qBnvy+14sCJHHfOFYamWJaaeNli3i6QZql4gsw VXO2S7EY50Xm2Qf+7QpQ84t07z39qK8jSKvOxNwNXMPr67LSoNCbZi17J29lOHnZ1Z0P BQo73mTGk0zlMBUoJBq7Mbqeh2TzEENzwi7nWWfaxX6Yo+nMOEvOu0CipM/4Njel+YWY Mk1mynDEeoxnWm3r0qXlPdiDWVs89+xjWeZQ3lEww11BrFVho8c716mquI8hKlkOKd+R AkbXDO5s2CkpeHKA8Od+ihpQkXMwHGTLbjFmaFQNo2Enedrl2p52xTIQbhtMVDKLoUJd +8ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date; bh=lzyeVchuUcxqGv3kfZu9EMEAZtJPF2MK9X7ggAJf2DQ=; b=vySJ/fgmaEPbpPd3G4x3a9CQr0Njcf66Fha7IybENF+5RNY3BW3PGT6EdbwQU+35q6 zy8/Oq+g8ljO09LMY1xEa86Q0MAr2W1k4yYB3WuGrI665upzkxlNQEeg0uTt2oNMK/cy 5RvS1Um2t3kbuy2UjaLx/zvMjnmQN3Qw7TJtv1WeObcDy7zDDSk7rIYNIz9PeMh/fBp+ d+lRsho09U3WRSG6rUzGq6zcxxakDcGGTT+4KYUKpcpG95+FqpSBxLczpugvwBBOMEm7 iVJ4YDNVUo9DczE9zUInFV6Ev4upwD5Tpa4L5gYjTjslAnqaDjgOKykL3p25kloCEDi0 YIyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i14si3214630edc.537.2021.07.13.10.00.56; Tue, 13 Jul 2021 10:01:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230402AbhGMRCq (ORCPT + 99 others); Tue, 13 Jul 2021 13:02:46 -0400 Received: from angie.orcam.me.uk ([78.133.224.34]:60606 "EHLO angie.orcam.me.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbhGMRCq (ORCPT ); Tue, 13 Jul 2021 13:02:46 -0400 Received: by angie.orcam.me.uk (Postfix, from userid 500) id C7CC792009C; Tue, 13 Jul 2021 18:59:54 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id BFC4D92009B; Tue, 13 Jul 2021 18:59:54 +0200 (CEST) Date: Tue, 13 Jul 2021 18:59:54 +0200 (CEST) From: "Maciej W. Rozycki" To: Pavel Skripkin cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: fddi: fix UAF in fza_probe In-Reply-To: <20210713105853.8979-1-paskripkin@gmail.com> Message-ID: References: <20210713105853.8979-1-paskripkin@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Jul 2021, Pavel Skripkin wrote: > fp is netdev private data and it cannot be > used after free_netdev() call. Using fp after free_netdev() > can cause UAF bug. Fix it by moving free_netdev() after error message. Can you justify the lines for a better layout? The paragraph looks odd to me in its current form. > Fixes: 61414f5ec983 ("FDDI: defza: Add support for DEC FDDIcontroller 700 > TURBOchannel adapter") > Signed-off-by: Pavel Skripkin Otherwise LGTM. And a good catch, thank you! Reviewed-by: Maciej W. Rozycki Maciej