Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Hunter, Adrian" <adrian.hunter@intel.com>
To:     Leo Yan <leo.yan@linaro.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
CC:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        "Namhyung Kim" <namhyung@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Borislav Petkov" <bp@alien8.de>,
        "x86@kernel.org" <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        "Suzuki K Poulose" <suzuki.poulose@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "coresight@lists.linaro.org" <coresight@lists.linaro.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v4 10/11] perf env: Set flag for kernel is 64-bit mode
Thread-Topic: [PATCH v4 10/11] perf env: Set flag for kernel is 64-bit mode
Thread-Index: AQHXdkFaHivs49Ex8kyMT64YmP+G0qs/pweAgAFeuoCAACa48A==
Date:   Tue, 13 Jul 2021 17:31:03 +0000
Message-ID: <PH0PR11MB56264B3A7E4709CB0635F320E0149@PH0PR11MB5626.namprd11.prod.outlook.com>
References: <20210711104105.505728-1-leo.yan@linaro.org>
 <20210711104105.505728-11-leo.yan@linaro.org> <YOyGi9Zdrio7OmBX@kernel.org>
 <20210713150953.GC748506@leoy-ThinkPad-X240s>
In-Reply-To: <20210713150953.GC748506@leoy-ThinkPad-X240s>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?e+pAA9TYVDhXHHo+jYZp6DYW/jBwSQq7pbL7yba3c4+jP4KnYWjeDSs3w7/M?=
 =?us-ascii?Q?fW02CIYFW21mI7lRu0Z2ogwzm3AJxYyXkEOMM5FRgDq2uBy4jxKzPmJDIO5e?=
 =?us-ascii?Q?5+novx01zPTt22S0Yq6WIsy/bjGxXL3UzGskj/7xL32q/C8o72UkimtMbUI0?=
 =?us-ascii?Q?9vHTxjlu2ZP3iaLKuFsCf0KFdmxxR7X226FGrrKApUWDJKXsTnHTyQdWhVzc?=
 =?us-ascii?Q?e96obOEuhgk4Ia6Sa7ZepP/9CPv50y9fSlYKUu8X/dncfNHUhk42Rs9hTH47?=
 =?us-ascii?Q?jKpkxCd4E7OeV4hlCvTFAZCloZMk4MQzxWDX0xcT4fH9mKHN6mG0HhZMsiPV?=
 =?us-ascii?Q?ofTPtvYgVrbwvD7luJcE47dwaTKeUkNmB79Bigj1VvRSuKI+TFtcouJm2ell?=
 =?us-ascii?Q?uHxl8e82elbLXkH8gs69uuTSMcUFeUMpk+nGlpsnDpTHrSuBS5oI494gIgW1?=
 =?us-ascii?Q?oronO+gmfisCiz2E9SCrrUvRcLE0CBCKckGHS2193nxS4QXVMdXSYKsZyTaF?=
 =?us-ascii?Q?f6LdbTB+l0e2eyq2l4arVH5W7++al/MhkBH0QnzxJV8LgCRoYcDyOFDlxNIe?=
 =?us-ascii?Q?mvgTvoL9eBWPTQwCkoY2jx+U2R5SR4BQ7DlVb+aMg5DT/FConeE/wWcItOW5?=
 =?us-ascii?Q?KQVDeE729rL677Desi1TsQxNZfdzwr6L/cnAUaTw1BwUikXgtqbL8NPm2aq+?=
 =?us-ascii?Q?70+jT70HYe9lpHsPxmyyYWmjmSf7qjqua9TQi4D9GFBaxNnZ80fN/WJX+jND?=
 =?us-ascii?Q?mtVWGfa6qQUy3/LO8Q/4cGg6aAw1F8bSBYoP8s/9xObf5ts5CeqVXC0rH1gp?=
 =?us-ascii?Q?iPyXUt3j52fF8j4tC6Mrtctjuke5pSbeDBEKDobLJyKFGLbiYAFrNbbRZ7x6?=
 =?us-ascii?Q?UdRBPBPTcQbsew6KGc3O616vl2/S8iVMw8Zw3PktpUmZnwFkJQEueMrIPBO8?=
 =?us-ascii?Q?JKD6tzCK+d3yey7ikvBLGcOeKM+wFwHH/0ohLBCJU9mLzL6P4J1r0+TOPahT?=
 =?us-ascii?Q?uix+w+2Z9o0k4d6pLGgyaXoroJqIVxZGbHI57ayNQ2dMNXqvznPyTlopwspt?=
 =?us-ascii?Q?JNv9SARkzDrh1dXHQK/9/yYwusoyRTS9aZGpvNx7+n8eI3FuQv6/AX/F3L9A?=
 =?us-ascii?Q?pKQ+Z/pdwIIEXqmhydUDsQO3/aqh4EUbAff0qM3Q+TkTXMl4Ybr7lQYo10XS?=
 =?us-ascii?Q?TsBUgTDyyaVt846YESzuxtOfqWc6ztNgHhZ2H8odpfQl0BssJUY/Kv08SjU?=
 =?us-ascii?Q?=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5626.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13636953-53a7-4603-3bd0-08d94623fd5c
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2021 17:31:03.7249
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dFZHfRtaveZ8vB4R681CKEuW6/G6gSQ8HNWrrwhWPykZUzR/TtmwY252GyKK7chIOIM/8BaNnj/gbIdmjyU2XQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5641
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Leo Yan <leo.yan@linaro.org>
> Sent: Tuesday, July 13, 2021 6:10 PM
> To: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Hunter, Adrian <adrian.hunter@intel.com>; Peter Zijlstra
> <peterz@infradead.org>; Ingo Molnar <mingo@redhat.com>; Mark Rutland
> <mark.rutland@arm.com>; Alexander Shishkin
> <alexander.shishkin@linux.intel.com>; Jiri Olsa <jolsa@redhat.com>;
> Namhyung Kim <namhyung@kernel.org>; Thomas Gleixner
> <tglx@linutronix.de>; Borislav Petkov <bp@alien8.de>; x86@kernel.org; H.
> Peter Anvin <hpa@zytor.com>; Mathieu Poirier
> <mathieu.poirier@linaro.org>; Suzuki K Poulose
> <suzuki.poulose@arm.com>; Mike Leach <mike.leach@linaro.org>; linux-
> perf-users@vger.kernel.org; linux-kernel@vger.kernel.org;
> coresight@lists.linaro.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH v4 10/11] perf env: Set flag for kernel is 64-bit mod=
e
>=20
> Hi Arnaldo, Adrian,
>=20
> On Mon, Jul 12, 2021 at 03:14:35PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Sun, Jul 11, 2021 at 06:41:04PM +0800, Leo Yan escreveu:
> > > It's useful to know that the kernel is running in 32-bit or 64-bit
> > > mode.  E.g. We can decide if perf tool is running in compat mode
> > > from this info.
> > >
> > > This patch adds a global variable "kernel_is_64_bit", it's
> > > initialized when a session setups environment, its value is decided
> > > by checking the architecture string.
> > >
> > > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> > > ---
> > >  tools/perf/util/env.c | 17 ++++++++++++++++-  tools/perf/util/env.h
> > > |  1 +
> > >  2 files changed, 17 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/tools/perf/util/env.c b/tools/perf/util/env.c index
> > > ebc5e9ad35db..345635a2e842 100644
> > > --- a/tools/perf/util/env.c
> > > +++ b/tools/perf/util/env.c
> > > @@ -11,6 +11,7 @@
> > >  #include <stdlib.h>
> > >  #include <string.h>
> > >
> > > +int kernel_is_64_bit;
> > >  struct perf_env perf_env;
> >
> > Why can't this be in 'struct perf_env'?
>=20
> Good question.  I considered to add it in struct perf_env but finally I u=
sed this
> way; the reason is this variable "kernel_is_64_bit" is only used during
> recording phase for AUX ring buffer, and don't use it for report.  So see=
ms to
> me it's over complexity to add a new field and just wander if it's necess=
ary to
> save this field as new feature in the perf header.

I think we store the arch, so if the "kernel_is_64_bit" calculation depends=
 only on arch
then I guess we don't need a new feature at the moment.

>=20
> Combining the comment from Adrian in another email, I think it's good to =
add
> a new field "compat_mode" in the struct perf_env, and this field will be
> initialized in build-record.c.  Currently we don't need to save this valu=
e into
> the perf file, if later we need to use this value for decoding phase, the=
n we
> can add a new feature item to save "compat_mode"
> into the perf file's header.
>=20
> If you have any different idea, please let me know.  Thanks!
>=20
> Leo