Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Jul 2021 19:39:03 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Apurva Nandan <a-nandan@ti.com>
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Pratyush Yadav <p.yadav@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 2/2] spi: cadence-quadspi: Fix check condition for DTR ops
Message-ID: <20210713183903.GH4098@sirena.org.uk>
References: <20210713125743.1540-1-a-nandan@ti.com>
 <20210713125743.1540-3-a-nandan@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="K1n7F7fSdjvFAEnM"
Content-Disposition: inline
In-Reply-To: <20210713125743.1540-3-a-nandan@ti.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--K1n7F7fSdjvFAEnM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jul 13, 2021 at 12:57:42PM +0000, Apurva Nandan wrote:

> +	f_pdata->dtr = op->cmd.dtr &&
> +		       (op->addr.dtr || !op->addr.nbytes) &&
> +		       (op->data.dtr || !op->data.nbytes);

I'm not sure anyone reading this code is going to figure out what it's
doing without thinking about it, the combination of writing the bytes
check with a !, putting it after the check for .dtr and not having any
comments is a bit obscure.  Something like

	(op->addr.nbytes && op.addr.dtr)

might be a bit clearer, or a comment explicitly spelling it out.

--K1n7F7fSdjvFAEnM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDt3cYACgkQJNaLcl1U
h9AkBAf9HBtavcaFb5fGRZa9jwV4sz1G1ZGGhYDjn+JTd/S/oMPd/BMpXsO4y1M+
5PBqgnG0bvl1hq/FQjupbs7BaiTTLWWAQjPYHIZaXoHIEiuSq7JI+Ryki0N+LFta
0YzL5ammBlGcvF2ZPfAm95dMaV83sBqkXJmdqzy8mVABe2Rw1iw9kx6kinLzk9X4
tBZnXOej3AhXr3FHjInBmZeWun/6TZ3dHQ4fKLvAWcnCeC8E5Z3lMG9VEYWDEbpd
SiT6VtjFsGDLzzV2+3eCVtnxU9Kzr5CmDhLsl2zBQ4nkq0s+8xIdUG9Op11V6yA6
BpdtzeCL+W0U7+YfEiSNFnvO/vHmEw==
=YkZ7
-----END PGP SIGNATURE-----

--K1n7F7fSdjvFAEnM--