Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Jul 2021 15:54:09 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Heiko Carstens <hca@linux.ibm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libperf: fix build error with LIBPFM4=1
Message-ID: <YO3hUUqRv5R/AxI5@kernel.org>
References: <20210713091907.1555560-1-hca@linux.ibm.com>
 <YO1dngCS/v0j3cAE@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YO1dngCS/v0j3cAE@krava>
Precedence: bulk

Em Tue, Jul 13, 2021 at 11:32:14AM +0200, Jiri Olsa escreveu:
> On Tue, Jul 13, 2021 at 11:19:07AM +0200, Heiko Carstens wrote:
> > Fix build error with LIBPFM4=1:
> >   CC      util/pfm.o
> > util/pfm.c: In function ‘parse_libpfm_events_option’:
> > util/pfm.c:102:30: error: ‘struct evsel’ has no member named ‘leader’
> >   102 |                         evsel->leader = grp_leader;
> >       |                              ^~
> > 
> > Fixes: fba7c86601e2 ("libperf: Move 'leader' from tools/perf to perf_evsel::leader")
> > Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> 
> Acked-by: Jiri Olsa <jolsa@redhat.com>

Argh, we have this in 'make -C tools/perf build-test'

⬢[acme@toolbox perf]$ grep libpfm tools/perf/tests/make
make_with_libpfm4   := LIBPFM4=1
run += make_with_libpfm4
⬢[acme@toolbox perf]$

But I forgot to install libpfm-devel :-\

Thanks, applied.

- Arnaldo