Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Jul 2021 15:46:59 -0600
From:   Rob Herring <robh@kernel.org>
To:     cy_huang <u0084500@gmail.com>
Cc:     broonie@kernel.org, lgirdwood@gmail.com,
        linux-kernel@vger.kernel.org, cy_huang@richtek.com,
        devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: rtq6752: Add binding document for Richtek
 RTQ6752
Message-ID: <20210713214659.GA892012@robh.at.kernel.org>
References: <1625845236-30285-1-git-send-email-u0084500@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1625845236-30285-1-git-send-email-u0084500@gmail.com>
Precedence: bulk

On Fri, Jul 09, 2021 at 11:40:35PM +0800, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
> 
> Add binding document for Richtek RTQ6752.
> 
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
>  .../regulator/richtek,rtq6752-regulator.yaml       | 78 ++++++++++++++++++++++
>  1 file changed, 78 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rtq6752-regulator.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq6752-regulator.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq6752-regulator.yaml
> new file mode 100644
> index 00000000..641840e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq6752-regulator.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/richtek,rtq6752-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Richtek RTQ6752 TFT LCD Voltage Regulator
> +
> +maintainers:
> +  - ChiYuan Huang <cy_huang@richtek.com>
> +
> +description: |
> +  The RTQ6752 is an I2C interface pgorammable power management IC. It includes
> +  two synchronous boost converter for PAVDD, and one synchronous NAVDD
> +  buck-boost. The device is suitable for automotive TFT-LCD panel.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - richtek,rtq6752
> +
> +  reg:
> +    maxItems: 1
> +
> +  enable-gpios:
> +    description: |
> +      A connection of the chip 'enable' gpio line. If not provided, treat it as
> +      external pull up.
> +    maxItems: 1
> +
> +  regulators:
> +    type: object
> +    $ref: regulator.yaml#

This node is not a regulator, just a container. Drop.

> +
> +    patternProperties:
> +      "^(p|n)avdd$":
> +        type: object
> +        $ref: regulator.yaml#
> +        description: |
> +          regulator description for pavdd and navdd.
> +
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - regulators
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      rtq6752@6b {
> +        compatible = "richtek,rtq6752";
> +        status = "okay";

Don't show status in examples.

> +        reg = <0x6b>;
> +        enable-gpios = <&gpio26 2 0>;
> +
> +        regulators {
> +          pavdd {
> +            regulator-name = "rtq6752-pavdd";
> +            regulator-min-microvolt = <5000000>;
> +            regulator-max-microvolt = <7300000>;
> +            regulator-boot-on;
> +          };
> +          navdd {
> +            regulator-name = "rtq6752-navdd";
> +            regulator-min-microvolt = <5000000>;
> +            regulator-max-microvolt = <7300000>;
> +            regulator-boot-on;
> +          };
> +        };
> +      };
> +    };
> -- 
> 2.7.4
> 
>