Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 0/3] Add SSIF BMC driver
To:     minyard@acm.org
Cc:     Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        Brendan Higgins <brendanhiggins@google.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Wolfram Sang <wsa@kernel.org>,
        openipmi-developer@lists.sourceforge.net,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org,
        Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>
References: <20210713055425.30636-1-quan@os.amperecomputing.com>
 <20210713154405.GB3406@minyard.net>
From:   Quan Nguyen <quan@os.amperecomputing.com>
Message-ID: <f7dd5b0f-a2a7-0a5f-3521-6721e8e52cb5@os.amperecomputing.com>
Date:   Wed, 14 Jul 2021 06:29:27 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.11.0
In-Reply-To: <20210713154405.GB3406@minyard.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2402:800:623c:5af9:f5a9:dac2:3878:4e29] (2402:800:623c:5af9:f5a9:dac2:3878:4e29) by HK0PR01CA0051.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Tue, 13 Jul 2021 23:29:42 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9f488e68-70ad-4b74-d0d3-08d9465619b3
X-MS-TrafficTypeDiagnostic: MW4PR01MB6291:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <MW4PR01MB62919D95B5586AF032AC024BF2149@MW4PR01MB6291.prod.exchangelabs.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: P6buRa/oRSuxsRx0RthzSGK0amzUWA0hLpK6MdJ3HTMYjaz9LN1onB33V6fw/9+MUHAFVtIF/RZh76au5TorJSOq20Trkcslk236o7H7uZWzH4lPYmO95G6NnTbfO1iNMfMnghiT8eFegfFYcaWtZ8SOzLtlvr0DPKwpd/EXi0PCXI6vfso4qR+rD3051lMnP9seiqk5pO9RHs98SrfvG8yJdMa9aUna32syawOAr4156UyrZI5pvdc0lWLUJgsSipXawpH7vSrT0yshpwh3viJHrLllT+JHH5H0k445mFQra8TvLcj+CKufmnVtYrDLG8x5oisSC5WZu6ARSXb5BTXBL+4i0wYZswYdGQOamSYAoLehx1UloJ0LYkEsD8YTHHsxkhtO7GC7lSLUZ2DX0skhYwDSbHqrR4KfrjNk74dOE7qQ3awKP0uWNOi91WyFzDwc6JtrmTdQFKeZzg7aa8TkrnsbMbGJw19ToD5awWSeu9DBt5zIHDHeF6VfSyk8IFHE4D5y81TIcrncIKIYylm3mKDZVDEEc8UGDQf6XTMMYKSkaYuIeO4NYK2mRMgewetQ/y9gep4mSWNDLf46ZYAxLrbOndq2xhkdUiiM+QvGGdQW97pmFhuJr+dXS0r6SLN3NZByfU96hGNE3tXA66CLXMoHPyu6WBNRd4LWfZDWQ+jJMDkbLobLLEqedoPdYdrBBk9vLeNVJEJaOsO8pQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW2PR0102MB3482.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(4636009)(39840400004)(376002)(366004)(136003)(346002)(396003)(31686004)(83380400001)(86362001)(66946007)(66556008)(6666004)(4326008)(66476007)(54906003)(31696002)(6916009)(186003)(38100700002)(5660300002)(478600001)(53546011)(7416002)(52116002)(8936002)(316002)(107886003)(8676002)(2616005)(6486002)(2906002)(43740500002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmNDZ0szMUpMMlRZbGlDb1lEeU5TT0RhTloyNGlQdEJPRWtkQ2tWZ2Frclhv?=
 =?utf-8?B?RENVVDhvTVNTeWVLNlAzVTI5ME5sWmdMdVV5L1NsTm54YzhKVnYzTnB5NE5o?=
 =?utf-8?B?cEhYWFlia3RZWU5zNTI3U1pOWTZPN1k3VXhuWXJtaHZWVTR4RXYyVUY0d05m?=
 =?utf-8?B?VHFpdGY3M2lmSFJodWh4UFIyTjJlcnhHOFVoQWFGQ05ldUVPV1dEdVFMUXN6?=
 =?utf-8?B?WGRJZ2ZyUHZrR0tkUlFSSlpxdFkzZzhTTm1vY3hUTnUySnYxTDVlWGFldDRm?=
 =?utf-8?B?NnNkSnVTUWh0QTAzZlB2WlE5U1FzZm91aUlrV0JmdUVCWGZPZi9PaEhvN3c5?=
 =?utf-8?B?aUxQalFlaEZ0OC9Id1lSQmQ4N1VnYXlFeCtRY0RxZEVteU9oQnhMSnNhVWJo?=
 =?utf-8?B?TW9HU3NJQVF2dTFNdnU1cXBJNDBwMDVwQngyRXI0R2hiaVVpdjFPcnk0bTR2?=
 =?utf-8?B?NDNhVFk4eTk5MG9mb1pvZXpya1FYS0hYUFdNLy9jY1VISzNCVzJKWk9zY0dX?=
 =?utf-8?B?ZVZLOEx3VFA2UWRqajBlMTRZMUJ3cEJtMkJFVDdGUWxraTZybTRTSlFONVlB?=
 =?utf-8?B?bi9hcUYyQjFCYVU2d3hrL0RqNWdCL1ppQURZMGI0WGNHazlTOC9TYUF0THd1?=
 =?utf-8?B?T01QYWdGcGRtQ0tzL284SlM3STYvNUdyYkZROGpPaWJrOW1CQmc4RTVZMDdK?=
 =?utf-8?B?LzR2dmpGWTFDUWpTalhKZWtaWUZWYXkrZXh6M25BcEdKbEU4U1MwMEVNOElj?=
 =?utf-8?B?L3VjSDBHUTNnU1IxMkZEUVV1bGV3M1hFUVd6RFNocXdlMGM1RFNIbi9Nbktj?=
 =?utf-8?B?Ui8zalRaSTc0UE1ySGdIejRadDR5UW94cWJTaU1Oek9XblNQTm9ydG5FS25t?=
 =?utf-8?B?c0JRNUw3cEM3dHFkbmRZSmlaY0Q5SVdXWUtlV0IzRFgzc1RIb1pETCtnbFJR?=
 =?utf-8?B?ZEYrbm9qeCt4aUszcHlLZGtQb213cklVQkg2a2p1OVFya3VSaE1HbjAxVzRW?=
 =?utf-8?B?NXVpOUdQZXc5dHlEZjE5TEpmQ3o4eFRGMFNteEx1L0F5NUkrK1lpMGNiZFBE?=
 =?utf-8?B?R3h4b1d6MnZEdHRnMDVJV3BHS3FTWjRsdGFZdHRnTDJIZWdhckZWdGM5OUVu?=
 =?utf-8?B?eXhZWWc2SGQwb3pVZnJacmFiRXRSQUJFLzZnaFdwbzlBUE9pcjVaRXdEaXhq?=
 =?utf-8?B?NTdrbHZhVXVFK2F4MkdyeEdQeTNpTVlRcW1hQU9kRnR1Nmsxb01pUzVudzBE?=
 =?utf-8?B?a3cwZWVMNk9rWVdwUFpCTWRCRkRjSXNmMk4yYlpWNm45L3ZWTnQyVXI5VWxu?=
 =?utf-8?B?Y2g3MkRCMHh6dkU0YUdUM1FBU09BK1dJM056c0ltUHJnN1hoamJIemlaZjA0?=
 =?utf-8?B?WGJVRlhYc0lraWNRRi85cHRuaW1DMzRyY1dROGxqNU9rUTNvR1pJRTdaaUI4?=
 =?utf-8?B?aXY2RGpiQ1lFa0cvT01Ea0JRVDBYbDNBVnJZVWxuQWR0Z2dkRStRbC9Pb3pm?=
 =?utf-8?B?WkcxeHEvM2ZkTkJTcUgxWFdZTTZVTllBWnVTTFY5TVA2OHk2TzdEK3lVV2s5?=
 =?utf-8?B?WVRWNFNnWmFVNWp1QUxDZE1BTCtiSDU5dkQ2MFN0NjdvNDZTRitYVXdPMk1k?=
 =?utf-8?B?Zjg4ZXp0amw3SnZlM3BPM0wxVWd6eUNweTBlY0diQVFiYVhYd0FFcW1qNXVQ?=
 =?utf-8?B?RkJnU0xBT2cxN3JHc0RacVNjZThVNlQ0T2pNQXE2Vi9oZ01OSUpHcVQzdm84?=
 =?utf-8?B?QldTWUwvVGNIdDN5aVpWS1Jlb3l0L0VmVDF6Zm5yL0hkNzZyVEN1Q3lLVWJy?=
 =?utf-8?B?R0p4dDh1bjFDaWJZeExaNDYxZUhweXdvd3ZjSUJNQTVqZkZEZFQvaEJsVjds?=
 =?utf-8?Q?yUmCRmn8i1Ng8?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f488e68-70ad-4b74-d0d3-08d9465619b3
X-MS-Exchange-CrossTenant-AuthSource: MW2PR0102MB3482.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2021 23:29:46.5430
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rDq+0aTSeB7lqfHEGihBEwVZsWu8i3mI/vNhmYRYRRuNJTuBg4/tIyHLfAFSSoRBMr32mqCGpoKCewz6I7k1QvPHlFB8Zga8wsqUBXaVMws=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR01MB6291
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13/07/2021 22:44, Corey Minyard wrote:
> On Tue, Jul 13, 2021 at 12:54:22PM +0700, Quan Nguyen wrote:
>> This series add support the SSIF BMC driver which is to perform in-band
>> IPMI communication with their host in management (BMC) side.
> 
> Per the kernel build robot, looks like patch 3 introduces slave_enable()
> but patch 1 uses it.
> 
> -corey
> 
Thanks Corey,

The order is not correct and kernel build robot found this hurts 
bisectibility.
The patch 3 should be the first patch.

- Quan

>>
>> SSIF BMC driver in this series is tested with Aspeed AST2500.
>>
>> v4:
>>    + Fix recursive spinlock                                      [Graeme]
>>    + Send response with Completion code 0xFF when aborting         [Quan]
>>    + Fix warning with dt_binding_check                              [Rob]
>>    + Change aspeed-ssif-bmc.yaml to ssif-bmc.yaml                  [Quan]
>>    + Added bounding check on SMBus writes and the whole request     [Dan]
>>    + Moved buffer to end of struct ssif_bmc_ctx to avoid context
>>      corruption if somehow buffer is written past the end           [Dan]
>>    + Return -EINVAL if userspace buffer too small, dont
>>      silence truncate                                       [Corey, Joel]
>>    + Not necessary to check NONBLOCK in lock                      [Corey]
>>    + Enforce one user at a time                                    [Joel]
>>    + Reject write with invalid response length from userspace     [Corey]
>>    + Add state machines for better ssif bmc state handling         [Quan]
>>    + Drop ssif_bmc_aspeed.c and make ssif_bmc.c is generic
>>      SSIF BMC driver                                               [Quan]
>>    + Change compatible string "aspeed,ast2500-ssif-bmc" to
>>      "ampere,ssif-bmc"                                             [Quan]
>>    + Toggle Slave enable in i2c-aspeed to turn on/off slave mode   [Ryan]
>>    + Added slave_enable() to struct i2c_algorithm to control
>>      slave mode and to address the recursive spinlock      [Graeme, Ryan]
>>    + Abort current request with invalid SMBus write or
>>      invalid command                                               [Quan]
>>    + Abort all request if there is pending response                [Quan]
>>    + Changed validate_pec() to validate_request()                  [Quan]
>>    + Add unsupported_smbus_cmd() to handle unknown SMBus command   [Quan]
>>    + Print internal state string for ease investigating issue      [Quan]
>>    + Move to READY state on SLAVE_STOP event                       [Quan]
>>    + Change initilize_transfer() to process_smbus_cmd()            [Quan]
>>    + Introduce functions for each slave event                      [Quan]
>>
>> v3:
>>    + Switched binding doc to use DT schema format [Rob]
>>    + Splited into generic ssif_bmc and aspeed-specific [Corey, Joel]
>>    + Removed redundant license info [Joel]
>>    + Switched to use traditional if-else [Joel]
>>    + Removed unused ssif_bmc_ioctl() [Joel]
>>    + Made handle_request()/complete_response() to return void [Joel]
>>    + Refactored send_ssif_bmc_response()/receive_ssif_bmc_request()
>>    [Corey]
>>    + Remove mutex [Corey]
>>    + Use spin_lock/unlock_irqsave/restore in callback [Corey]
>>    + Removed the unnecessary memset [Corey]
>>    + Switch to use dev_err() [Corey]
>>    + Combine mask/unmask two interrupts together [Corey]
>>    + Fixed unhandled Tx done with NAK [Quan]
>>    + Late ack'ed Tx done w/wo Ack irq [Quan]
>>    + Use aspeed-specific exported aspeed_set_slave_busy() when slave busy
>>    to fix the deadlock [Graeme, Philipp, Quan]
>>    + Clean buffer for last multipart read [Quan]
>>    + Handle unknown incoming command [Quan]
>>
>> v2:
>>    + Fixed compiling error with COMPILE_TEST for arc
>>
>> Quan Nguyen (3):
>>    ipmi: ssif_bmc: Add SSIF BMC driver
>>    bindings: ipmi: Add binding for SSIF BMC driver
>>    i2c: aspeed: Add slave_enable() to toggle slave mode
>>
>>   .../devicetree/bindings/ipmi/ssif-bmc.yaml    |  38 +
>>   drivers/char/ipmi/Kconfig                     |  11 +
>>   drivers/char/ipmi/Makefile                    |   1 +
>>   drivers/char/ipmi/ssif_bmc.c                  | 781 ++++++++++++++++++
>>   drivers/char/ipmi/ssif_bmc.h                  | 106 +++
>>   drivers/i2c/busses/i2c-aspeed.c               |  20 +
>>   include/linux/i2c.h                           |   2 +
>>   7 files changed, 959 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml
>>   create mode 100644 drivers/char/ipmi/ssif_bmc.c
>>   create mode 100644 drivers/char/ipmi/ssif_bmc.h
>>
>> -- 
>> 2.28.0
>>