Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 14 Jul 2021 11:12:05 +1000 (AEST)
From:   Finn Thain <fthain@linux-m68k.org>
To:     =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/5] bus: Make remove callback return void
In-Reply-To: <20210713193522.1770306-6-u.kleine-koenig@pengutronix.de>
Message-ID: <1a4ba24-8bab-47b8-b25d-cc31ce16ca1f@linux-m68k.org>
References: <20210713193522.1770306-1-u.kleine-koenig@pengutronix.de> <20210713193522.1770306-6-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="-1463811774-790401653-1626225063=:6"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1463811774-790401653-1626225063=:6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Tue, 13 Jul 2021, Uwe Kleine-K=C3=B6nig wrote:

> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
>=20
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
>=20
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
>=20

=2E..

> diff --git a/drivers/nubus/bus.c b/drivers/nubus/bus.c
> index ad3d17c42e23..d9d04f27f89b 100644
> --- a/drivers/nubus/bus.c
> +++ b/drivers/nubus/bus.c
> @@ -29,14 +29,12 @@ static int nubus_device_probe(struct device *dev)
>  =09return err;
>  }
> =20
> -static int nubus_device_remove(struct device *dev)
> +static void nubus_device_remove(struct device *dev)
>  {
>  =09struct nubus_driver *ndrv =3D to_nubus_driver(dev->driver);
> -=09int err =3D -ENODEV;
> =20
>  =09if (dev->driver && ndrv->remove)
> -=09=09err =3D ndrv->remove(to_nubus_board(dev));
> -=09return err;
> +=09=09ndrv->remove(to_nubus_board(dev));
>  }
> =20
>  struct bus_type nubus_bus_type =3D {

Acked-by: Finn Thain <fthain@linux-m68k.org>
---1463811774-790401653-1626225063=:6--