Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [smartpqi updates V2 PATCH 5/9] smartpqi: add SCSI cmd info for
 resets
To:     Don Brace <don.brace@microchip.com>, hch@infradead.org,
        martin.peterson@oracle.com, jejb@linux.vnet.ibm.com,
        linux-scsi@vger.kernel.org
Cc:     Kevin.Barnett@microchip.com, scott.teel@microchip.com,
        Justin.Lindley@microchip.com, scott.benesh@microchip.com,
        gerry.morong@microchip.com, mahesh.rajashekhara@microchip.com,
        mike.mcgowen@microchip.com, murthy.bhat@microchip.com,
        balsundar.p@microchip.com, joseph.szczypek@hpe.com,
        jeff@canonical.com, POSWALD@suse.com, mwilck@suse.com,
        pmenzel@molgen.mpg.de, linux-kernel@vger.kernel.org
References: <20210713210243.40594-1-don.brace@microchip.com>
 <20210713210243.40594-6-don.brace@microchip.com>
From:   John Donnelly <john.p.donnelly@oracle.com>
Message-ID: <27638adc-44a3-45dc-2d15-6c08fbc28f85@oracle.com>
Date:   Tue, 13 Jul 2021 20:14:38 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <20210713210243.40594-6-don.brace@microchip.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.106] (47.220.66.60) by DM5PR06CA0027.namprd06.prod.outlook.com (2603:10b6:3:5d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Wed, 14 Jul 2021 01:14:41 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: bd9a963c-4918-402f-d2f7-08d94664c2d0
X-MS-TrafficTypeDiagnostic: CO1PR10MB4451:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB4451BD26DC3CF9309A098B7AC7139@CO1PR10MB4451.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 8gOAXSVSfqVtY6fN3HoErfYt87QUhrTu8T4n2xKF6ZERdv5xIq87yETEVgS7+2QqfiAZv1q4/08gOkQ6vxZnt4T2BYpMo1EOp3hk0RafQX7QVyqTA7y5WBlXCnlG7MPHdGFE7GnfOPXHDGS+Bl8FfnBc+0HUIzPGJGwLwleOruzUefg08fZF6eXR1d4lsqRQNw8kmY1e8T+NEmiQintvUpfL6JBtQNGMgrK51Zmu5tz3vnX1FneyNtXqMl8RTSvdewL7PYdWAznZ5C2R65WCvyQCGkNKixCO0A0JCAEl7N7NXGOFZVHrbDu0k61lD/Ea4yEQcH8Y5dMrem2PH9gDkwBvded5q8RUB8VsQZeX+7FqQ8/tEnzyKVtL94lvlz/chImrLJe/93cUh4UJfq11WeOtz0BbGaet5A1aEGgqA+sCEH0BsWLE1T9La75JZfLYPogA9Der6l/jU/CkMSo/n0LIMvnFbMbHb55IoseYvN9d4v7CAmXoloYixlgJq68c1fW/a3j2FWnuW1zk0Q/PgGddEQjEe4a+rT5JxxoRrTTYxs0HFSGSgLo+V7ngZQ5rn9FM96DpSYID5YUOuo4/ioZoXVJns+GraF06oqFxAeFoEY6GYvHJYwBATNiqu+S3Lg5BxsB6i7NplUPqbA+VcDMmeiG1sl0m9Fil9B02H+RiTWSIhldzHQdYhQmBm5KhAUjfT1T7r289uQpgeT/qluEe7SdRTwxxeYYGiqjA4MM=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4722.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(136003)(346002)(376002)(366004)(83380400001)(7416002)(66476007)(16576012)(66946007)(956004)(2616005)(478600001)(316002)(36756003)(66556008)(6666004)(6486002)(8936002)(5660300002)(31686004)(186003)(4326008)(86362001)(26005)(2906002)(38100700002)(8676002)(31696002)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3RHRHRPMUlPQ0E4YVd5MUZBaW5hamx5MDYzN3NQYkQxRTI3SU4xaUxnTUxX?=
 =?utf-8?B?b1g3Q0h2NklaaUNXRE5id1V4Y0p5QkQyekdPajdrTXlUR0pqTm44Z0hiZ1g4?=
 =?utf-8?B?NXFTdFFIaWVYYkFQU3duRHIzUzlGYkgzejNZb3lkdGg0SlVORVg3OTFwY3V6?=
 =?utf-8?B?ZGpIZnRkTCttZzZ6UEVBK3JpaHVPTmRMSTF0SStUamdoRkl2a29CL2poRUR6?=
 =?utf-8?B?dUZCeElqOFNKWW1DQnVlSEhqZEFVNUVtUzVuOTBJMU5nQ2NyTlJpSkxWSDBV?=
 =?utf-8?B?bUZFSWlDMDZoR3RidUM0TkljYnMyZHdxOWZsd29RN213YkxJSUhybGxuZ254?=
 =?utf-8?B?R0dFM2h0SjdNZERjK3lWdkhNZUI3VThxRmhlODJGRlF6aHpNYU5FRFR6S0JO?=
 =?utf-8?B?THNjejllOFdhUEVya3d2OVRyR1VORGRXV0FabE81MWpzU21WT0ZQelNLL1J0?=
 =?utf-8?B?TW1OczhuMnZiM2lMNi9QZ2M0Y2lhOWx0b2NqOXB6YXlocnZPUCtQMHp5dlJY?=
 =?utf-8?B?Vi92VXo4b0VYT0JsQUZobXhzNEFmUC9yTlpmckZWTXR2Q200TXM0MnRNYmxu?=
 =?utf-8?B?ejk1QXBGcmZISjhBY2JmUlhSZGN4azRablE1UmNmWFFNRHhJL3hYTWNRWC9K?=
 =?utf-8?B?ZVlIS0VKcVkzM3M1K2FBU3JYVVoxMm9hSnVvYXlwSExhSGFjVzVYSzdqY3Ra?=
 =?utf-8?B?UGlvOEJBQTVvSnBuR1ZlNDBPL0tLM0FvbEZkOGZiRVNla0ZaSEsyOVJHR2Z5?=
 =?utf-8?B?MmVsREJFaXdlcWk1R3oyZ1U3QjRrMlh3eVlUclVHZk8yL3NTaitRbEMvdkwz?=
 =?utf-8?B?Yml5cTFrOVNEVGhiRGxjM0hvNjlQaUZ4aU9aQ2xXV25yYkF2a2Vmd0lPZmZ6?=
 =?utf-8?B?ZEdDSld6UXB4Sml0NS9PS3YrczlreW1KeDBpMmtjejhZbWd2cE10NFNvOHlt?=
 =?utf-8?B?N08vWk1TckRRZUw0UEJFdSszdzRUNEdQRVBkYi9qSVU2Zjhxc1duKzlDdmR6?=
 =?utf-8?B?UGpaYWN2TW9oY3FGZUlYU3hGQ0hKcEx1eW53RFVsZ2lxOTFQWkhodDhxczdv?=
 =?utf-8?B?anF1bVNiZ2hYNGdQdzNaSU9ZNkpidE1IMkxXSmtvejJvTTl4SW1hNkltOXRD?=
 =?utf-8?B?M3FsTkNhL0xuT3FmSWg4S1ZGay82T0huSkFMVTJRdDdvaGtJcXg4aElRcmZV?=
 =?utf-8?B?ZmkxMGFGeVQ1MjhLQ1RMZi93NU1rUmZDSmx0VlN5RlZRYnRjaGlVTm1qandK?=
 =?utf-8?B?YXQrLy8zZWM5Ky96YWhCM1ZHMCtRMDZLbkJHSTlidFJ2ODhXWnlNMlRxZCtj?=
 =?utf-8?B?YnJuVU9TS0s0Mm5nSFRRUGNSbnN3N2Q3Y2hYU3VKM2hIVkFhNXVZT1NrcmhE?=
 =?utf-8?B?UjVRZ09scHJSTUZnOHdyL244a2dQRTZzV0FLcVVLYzh1aWh0OUc3SGNtV2V2?=
 =?utf-8?B?VWlHZEdaS3dISHpua1BJbGlNcFJVUkZZVHFGOEwzZFVvVGcwSXVvdm9keUky?=
 =?utf-8?B?SEdKZk9WeWszOXZkZGZuRmNEcjlMZG5vRWd1UnhWMVpaeDFIcERGSXovWjl5?=
 =?utf-8?B?dzY2UEpkRVViS0xyM05LQlFyR3UxNkp4d3dDRnJXUFpLNkgybVVPZ2FSOUZo?=
 =?utf-8?B?REJVaEZrdzI5N3lxRVpVMDl3L1BQdE9GdUxROGhoTlpRRWVyVUtKOStLRENO?=
 =?utf-8?B?QkZvN21DOU80Ui9LNEhIUVkwekNNZk4wVnhLZW9LU0NhMXY1bElWREVsZmww?=
 =?utf-8?Q?Ogj9uCY5ROarBSijYav2kPDjC/+qmlx7yfybo6E?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd9a963c-4918-402f-d2f7-08d94664c2d0
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4722.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2021 01:14:43.0288
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5UiQvntRnwl8xZ+34aj/BvkpRSxUFobqoJTtoxSdZtGXKkPTFsRzEXdI7ZTwxuRsoARI0nA/6IyQJ7emlxaj2/w+10eedkpAM7LRbwSWlYc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4451
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10044 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 phishscore=0 adultscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2107140004
X-Proofpoint-ORIG-GUID: pkbJif95Jkit6NlWeG8Q9hpXqOpgbywo
X-Proofpoint-GUID: pkbJif95Jkit6NlWeG8Q9hpXqOpgbywo
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/13/21 4:02 PM, Don Brace wrote:
> From: Murthy Bhat <Murthy.Bhat@microchip.com>
> 
> Report on SCSI command that has triggered the reset.
>   - Also add check for NULL SCSI commands resulting from
>     issuing sg_reset when there is no outstanding commands.
> 
>     Example:
>     sg_reset -d /dev/sgXY
>     smartpqi 0000:39:00.0: resetting scsi 4:0:1:0 due to cmd 0x12
> 
> Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com>
> Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
> Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
> Reviewed-by: Scott Teel <scott.teel@microchip.com>
> Signed-off-by: Murthy Bhat <Murthy.Bhat@microchip.com>
> Signed-off-by: Don Brace <don.brace@microchip.com>

  John Donnelly <john.p.donnelly@oracle.com>

> ---
>   drivers/scsi/smartpqi/smartpqi_init.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
> index 29382b290243..ffc7ca221e27 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -6033,8 +6033,10 @@ static int pqi_eh_device_reset_handler(struct scsi_cmnd *scmd)
>   	mutex_lock(&ctrl_info->lun_reset_mutex);
>   
>   	dev_err(&ctrl_info->pci_dev->dev,
> -		"resetting scsi %d:%d:%d:%d\n",
> -		shost->host_no, device->bus, device->target, device->lun);
> +		"resetting scsi %d:%d:%d:%d due to cmd 0x%02x\n",
> +		shost->host_no,
> +		device->bus, device->target, device->lun,
> +		scmd->cmd_len > 0 ? scmd->cmnd[0] : 0xff);
>   
>   	pqi_check_ctrl_health(ctrl_info);
>   	if (pqi_ctrl_offline(ctrl_info))
>