Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210713130344.473646-1-mudongliangabcd@gmail.com>
 <20210713132059.GB11179@breakpoint.cc> <CAD-N9QV7pt3PCzUK2r03aB_URU5Auu+quC+DJpc=46hjkceBNg@mail.gmail.com>
 <20210713153115.GC11179@breakpoint.cc>
In-Reply-To: <20210713153115.GC11179@breakpoint.cc>
From:   Dongliang Mu <mudongliangabcd@gmail.com>
Date:   Wed, 14 Jul 2021 10:18:36 +0800
Message-ID: <CAD-N9QWmNYPkim_KrnUfvNhErUZaJqwGH-_3QvivVEvg+KnHjA@mail.gmail.com>
Subject: Re: [PATCH v2] audit: fix memory leak in nf_tables_commit
To:     Florian Westphal <fw@strlen.de>
Cc:     Pablo Neira Ayuso <pablo@netfilter.org>,
        Jozsef Kadlecsik <kadlec@netfilter.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Richard Guy Briggs <rgb@redhat.com>,
        Paul Moore <paul@paul-moore.com>,
        syzbot <syzkaller@googlegroups.com>,
        kernel test robot <lkp@intel.com>,
        netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jul 13, 2021 at 11:31 PM Florian Westphal <fw@strlen.de> wrote:
>
> Dongliang Mu <mudongliangabcd@gmail.com> wrote:
> > > > +static void nf_tables_commit_free(struct list_head *adl)
> > >
> > > nf_tables_commit_audit_free?
> >
> > What do you mean? Modify the name of newly added function to
> > nf_tables_commit_audit_free?
>
> Yes, this function is audit related, and it does the inverse
> of existing '...audit_alloc'.

Hi Florian,

I double-check the patch, and it seems there is no need to send a
followup patch (nf-next).

I will send a v3 patch with the new function name.

Best regards
Dongliang Mu