Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f3d58a9a27e255ba5b05f8f043ef649fb74fe993.camel@perches.com>
Subject: Re: [PATCH] replace for loop with array initializer
From:   Joe Perches <joe@perches.com>
To:     Stephen Hemminger <stephen@networkplumber.org>,
        Salah Triki <salah.triki@gmail.com>
Cc:     kevin.curtis@farsite.co.uk, davem@davemloft.net, kuba@kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 13 Jul 2021 21:08:14 -0700
In-Reply-To: <20210712130520.748b6e3a@hermes.local>
References: <20210712192450.GA1153790@pc>
         <20210712130520.748b6e3a@hermes.local>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2021-07-12 at 13:05 -0700, Stephen Hemminger wrote:
> On Mon, 12 Jul 2021 20:24:50 +0100 Salah Triki <salah.triki@gmail.com> wrote:
> > diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c
[]
> > +static struct fst_card_info *fst_card_array[FST_MAX_CARDS] = { [0 ... FST_MAX_CARDS-1] = NULL };
> 
> Why bother, the default initialization in C is 0 (ie. NULL).
> In fact, checkpatch should complain about useless array initialization for this.

I'll look out for your patch to checkpatch.