Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= <jose.exposito89@gmail.com>
To:     juw@posteo.de
Cc:     alexhenrie24@gmail.com, benjamin.tissoires@redhat.com,
        jikos@kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: BUG: cannot enable iso_layout with apple keyboard
Date:   Wed, 14 Jul 2021 09:57:23 +0200
Message-Id: <20210714075723.17294-1-jose.exposito89@gmail.com>
In-Reply-To: <20210708141935.bx33mv2jxtm752z3@julianexternal>
References: <20210708141935.bx33mv2jxtm752z3@julianexternal>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

> Hi,
> 
> I have an apple keyboard model A1644 EMC 2815 with Finnish/Swedish ISO layout. When I connect it via 
> cable it works fine. But when I connect it via bluetooth, then the buttons >/< and §/° are swapped.
> It seems to make no difference if I set iso_layout to 0 or to 1. I checked and it turns out that
> hid->country below equals 0, and removing the check
> 
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index 6b8f0d004d34..8a764ce4e518 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -267,13 +267,11 @@ static int hidinput_apple_event(struct hid_device *hid, struct input_dev *input,
>         }
> 
>         if (iso_layout) {
> -               if (hid->country == HID_COUNTRY_INTERNATIONAL_ISO) {
>                         trans = apple_find_translation(apple_iso_keyboard, usage->code);
>                         if (trans) {
>                                 input_event(input, usage->type, trans->to, value);
>                                 return 1;
>                         }
> -               }
>         }
> 
>         if (swap_opt_cmd) {
> 
> makes the buttons act correctly. Please let me know how I can help fixing this.
> 
> Best regards,
> Julian Weigt

Hi Julian,

I can confirm I can reproduce the issue with a Spanish/Spain keyboard.

The problem seems to be that the field "bCountryCode" is not present when the keyboard is connected over bluetooth.

CCing Alex Henrie, hopefully he can add useful information about the issue.

Best wishes,
Jose