Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 14 Jul 2021 09:52:44 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Michael Kelley <mikelley@microsoft.com>
Cc:     sthemmin@microsoft.com, kys@microsoft.com, wei.liu@kernel.org,
        decui@microsoft.com, daniel.lezcano@linaro.org, tglx@linutronix.de,
        arnd@arndb.de, linux-kernel@vger.kernel.org,
        linux-hyperv@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers: hv: Decouple Hyper-V clock/timer code from
 VMbus drivers
Message-ID: <20210714095244.wcnmp5mxvehdq3zj@liuwe-devbox-debian-v2>
References: <1626220906-22629-1-git-send-email-mikelley@microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1626220906-22629-1-git-send-email-mikelley@microsoft.com>
Precedence: bulk

On Tue, Jul 13, 2021 at 05:01:46PM -0700, Michael Kelley wrote:
[...]
>  
> diff --git a/include/clocksource/hyperv_timer.h b/include/clocksource/hyperv_timer.h
> index b6774aa..1c566c7 100644
> --- a/include/clocksource/hyperv_timer.h
> +++ b/include/clocksource/hyperv_timer.h
> @@ -20,6 +20,8 @@
>  #define HV_MAX_MAX_DELTA_TICKS 0xffffffff
>  #define HV_MIN_DELTA_TICKS 1
>  
> +#ifdef CONFIG_HYPERV_TIMER
> +
>  /* Routines called by the VMbus driver */
>  extern int hv_stimer_alloc(bool have_percpu_irqs);
>  extern int hv_stimer_cleanup(unsigned int cpu);
> @@ -28,8 +30,6 @@
>  extern void hv_stimer_global_cleanup(void);
>  extern void hv_stimer0_isr(void);
>  
> -#ifdef CONFIG_HYPERV_TIMER
> -extern u64 (*hv_read_reference_counter)(void);
>  extern void hv_init_clocksource(void);
>  
>  extern struct ms_hyperv_tsc_page *hv_get_tsc_page(void);
> @@ -100,6 +100,13 @@ static inline u64 hv_read_tsc_page_tsc(const struct ms_hyperv_tsc_page *tsc_pg,
>  {
>  	return U64_MAX;
>  }
> +
> +static inline int hv_stimer_cleanup(unsigned int cpu) {return 0; }

Nit: missing space before "return". No need to resend just for this.

Wei.