Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Date:   Wed, 14 Jul 2021 16:02:56 +0300
From:   Leon Romanovsky <leonro@nvidia.com>
To:     Nitesh Lal <nilal@redhat.com>
CC:     Nitesh Narayan Lal <nitesh@redhat.com>,
        <linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-api@vger.kernel.org>, <linux-pci@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Jesse Brandeburg" <jesse.brandeburg@intel.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        Ingo Molnar <mingo@kernel.org>, <jbrandeb@kernel.org>,
        <frederic@kernel.org>, Juri Lelli <juri.lelli@redhat.com>,
        Alex Belits <abelits@marvell.com>,
        Bjorn Helgaas <bhelgaas@google.com>, <rostedt@goodmis.org>,
        <peterz@infradead.org>, <davem@davemloft.net>,
        <akpm@linux-foundation.org>, <sfr@canb.auug.org.au>,
        <stephen@networkplumber.org>, <rppt@linux.vnet.ibm.com>,
        <chris.friesen@windriver.com>, Marc Zyngier <maz@kernel.org>,
        Neil Horman <nhorman@tuxdriver.com>, <pjwaskiewicz@gmail.com>,
        Stefan Assmann <sassmann@redhat.com>,
        Tomas Henzl <thenzl@redhat.com>, <kashyap.desai@broadcom.com>,
        Sumit Saxena <sumit.saxena@broadcom.com>,
        <shivasharan.srikanteshwara@broadcom.com>,
        <sathya.prakash@broadcom.com>,
        Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
        <suganath-prabu.subramani@broadcom.com>,
        <james.smart@broadcom.com>, <dick.kennedy@broadcom.com>,
        Ken Cox <jkc@redhat.com>, <faisal.latif@intel.com>,
        <shiraz.saleem@intel.com>, <tariqt@nvidia.com>,
        Alaa Hleihel <ahleihel@redhat.com>,
        Kamal Heib <kheib@redhat.com>, <borisp@nvidia.com>,
        <saeedm@nvidia.com>, <benve@cisco.com>, <govind@gmx.com>,
        <jassisinghbrar@gmail.com>, <ajit.khaparde@broadcom.com>,
        <sriharsha.basavapatna@broadcom.com>, <somnath.kotur@broadcom.com>,
        "Nikolova, Tatyana E" <tatyana.e.nikolova@intel.com>,
        "Ismail, Mustafa" <mustafa.ismail@intel.com>,
        Al Stone <ahs3@redhat.com>,
        Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Subject: Re: [PATCH v3 06/14] RDMA/irdma: Use irq_set_affinity_and_hint
Message-ID: <YO7ggLW78FWE4z+1@unreal>
References: <20210713211502.464259-1-nitesh@redhat.com>
 <20210713211502.464259-7-nitesh@redhat.com>
 <YO7SiFE1dE0dFhkE@unreal>
 <CAFki+Lm-CpKZai1fV5aMJzEb-x+003m8wLQShSrYpyNh3XC50Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAFki+Lm-CpKZai1fV5aMJzEb-x+003m8wLQShSrYpyNh3XC50Q@mail.gmail.com>
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2021 13:03:01.4573
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 29cf5632-499e-4e1a-2dfb-08d946c7b601
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT006.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3364
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 14, 2021 at 08:56:41AM -0400, Nitesh Lal wrote:
> On Wed, Jul 14, 2021 at 8:03 AM Leon Romanovsky <leonro@nvidia.com> wrote:
> >
> > On Tue, Jul 13, 2021 at 05:14:54PM -0400, Nitesh Narayan Lal wrote:
> > > The driver uses irq_set_affinity_hint() to update the affinity_hint mask
> > > that is consumed by the userspace to distribute the interrupts and to apply
> > > the provided mask as the affinity for its interrupts. However,
> > > irq_set_affinity_hint() applying the provided cpumask as an affinity for
> > > the interrupt is an undocumented side effect.
> > >
> > > To remove this side effect irq_set_affinity_hint() has been marked
> > > as deprecated and new interfaces have been introduced. Hence, replace the
> > > irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
> > > where the provided mask needs to be applied as the affinity and
> > > affinity_hint pointer needs to be set and replace with
> > > irq_update_affinity_hint() where only affinity_hint needs to be updated.
> > >
> > > Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com>
> > > ---
> > >  drivers/infiniband/hw/irdma/hw.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/irdma/hw.c
> > > index 7afb8a6a0526..7f13a051d4de 100644
> > > --- a/drivers/infiniband/hw/irdma/hw.c
> > > +++ b/drivers/infiniband/hw/irdma/hw.c
> > > @@ -537,7 +537,7 @@ static void irdma_destroy_irq(struct irdma_pci_f *rf,
> > >       struct irdma_sc_dev *dev = &rf->sc_dev;
> > >
> > >       dev->irq_ops->irdma_dis_irq(dev, msix_vec->idx);
> > > -     irq_set_affinity_hint(msix_vec->irq, NULL);
> > > +     irq_update_affinity_hint(msix_vec->irq, NULL);
> > >       free_irq(msix_vec->irq, dev_id);
> > >  }
> > >
> > > @@ -1087,7 +1087,7 @@ irdma_cfg_ceq_vector(struct irdma_pci_f *rf, struct irdma_ceq *iwceq,
> > >       }
> > >       cpumask_clear(&msix_vec->mask);
> > >       cpumask_set_cpu(msix_vec->cpu_affinity, &msix_vec->mask);
> > > -     irq_set_affinity_hint(msix_vec->irq, &msix_vec->mask);
> > > +     irq_set_affinity_and_hint(msix_vec->irq, &msix_vec->mask);
> >
> > I think that it needs to be irq_update_affinity_hint().
> >
> 
> Ah! I got a little confused from our last conversation about mlx5.
> 
> IIUC mlx5 sub-function use case uses irdma (?) and that's why I thought
> that perhaps we would also want to define the affinity here from the beginning.

mlx5 is connected to mlx5_ib/mlx5_vdpa e.t.c.

Not sure about that, but I think that only mlx5 implements SIOV model.

> 
> In any case, I will make the change and re-post.
> 
> --
> Thanks
> Nitesh
>