Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 14 Jul 2021 09:22:33 -0400
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
To:     20210712162655.w3j6uczwbfkzazvt@oracle.com
Cc:     bsegall@google.com, dietmar.eggemann@arm.com,
        juri.lelli@redhat.com, linux-kernel@vger.kernel.org,
        mingo@redhat.com, peterz@infradead.org, pjt@google.com,
        vincent.guittot@linaro.org, zhangqiao22@huawei.com
Subject: Re: [PATCH -next] sched: Dec __cfs_bandwith_used in
 destroy_cfs_bandwidth()
Message-ID: <20210714132233.o4zvgdiiugxf6yxk@oracle.com>
References: <3b2eb2c6-20d5-9f13-09f9-77f87f333b8d@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3b2eb2c6-20d5-9f13-09f9-77f87f333b8d@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from oracle.com (98.229.125.203) by BL1PR13CA0434.namprd13.prod.outlook.com (2603:10b6:208:2c3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.14 via Frontend Transport; Wed, 14 Jul 2021 13:22:37 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e2968610-f947-45bc-ac22-08d946ca7394
X-MS-TrafficTypeDiagnostic: BYAPR10MB2758:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR10MB2758F3F11650A8B4DE4232B9D9139@BYAPR10MB2758.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4714;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +pp90olfDUnOpgSCe39guLRLIk+252D2OlrGgHDbmVodbRPsGzONrGFe/cxvSPufBow0TkEt5/87Q+wINlHsfoKMRV3jxe7GDOgzoOKx53Q0EDYa1U9rfPPK4DyU8cXgS3kzZ9oQJYIqqYZCFZBzvlhWKQ+2I1GBcfg/5zWtL8nCQ7VeM+c+k4m1+QodPbzQuOgNaesx6zZReiOcRZSqCsPzKgWr+l5rWrkKTyR4sNcAO9/L+k1aRe/iY1ONFrjdorx9kLdhUZFcOnCmyBFhqCpVUWdO38lfMzlETpPML8AGBz3czrcaSSn6b+OnGFKIZuNq9EVbmMzg0/whXCca20lLNGti0nOeVu8/fIjtJB9Skp7kf8A9UkHjyaObzvLL3jXRohg+5chlJ9es+LoSLQKTJGiBg7xfjnPWaw6rzDikuzAQt0bPpaVWgvem6LRpypEj8VS6INk5RrK7mAoNlOJGXNMCpq+pQd2A3ofLVtEueZUQnOO3XuDBWg3wtRq7XOa0m6FVlVonWBPqaHfdmA5KbiEgZn1ORnQqx1OXXGEqO7Ox05kRFMOkgnzyw9OPWvlPkCz7csL/14CMiADGoFuZPaqTPf0/U/dG2uMen74mGxSucCrFWwj2yD8JknpfKOJwwC1VZLTc5v7qv7tizvi01dZ1Z5GgD+BSnQ2oFNTqxFqAxwAGtHdzeGttfpEgGxpGoq/an/z7NlpazDEzPw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2966.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(39860400002)(366004)(136003)(396003)(376002)(37006003)(83380400001)(34206002)(5660300002)(6636002)(36756003)(1076003)(4744005)(52116002)(7696005)(38350700002)(6666004)(26005)(38100700002)(8936002)(478600001)(2616005)(316002)(66946007)(186003)(55016002)(8676002)(66556008)(66476007)(8886007)(2906002)(86362001)(956004)(4326008);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nJtnutNWB7r8l0fHzTKOMRoj718bUjoSNRjq2zpwB1sX/PiVqhAS6Bs9aC75?=
 =?us-ascii?Q?xlYTC08GtH/jkZRrTbQE73jb0lcY5M4zAWe3SCtK6Ta27szmhgE4eNbS1gpO?=
 =?us-ascii?Q?WVfVwJWhMVw4ZCfX08WNtrXKyyUNVXQV2H4n+52h26sD0TngQTTnb5+BzkLA?=
 =?us-ascii?Q?Nn2pAeof6j+Ksa3fwzIk2fIbuN/cJtFiKMRaJGm5dc4nPR1mkiClZBraRj71?=
 =?us-ascii?Q?hpaNO101SHZD3yxN3G9Qa3hVOlQRIBv7oyVz1YhXJfYGal3qwNgXlLRcj2Dy?=
 =?us-ascii?Q?v/jVJWDPnzvGedeKH9dSBOo74gA5fOq0/paD6HazpiWPELoyE+ytTMun31Nc?=
 =?us-ascii?Q?j4Z78ujMHW9BsZW6YkjYyiFFwRXxmRoS2lTv4+QMNRMyt2IWoZ+3HQFTH2jX?=
 =?us-ascii?Q?X5WWFHStor15skhK4ZuDK/oizucg7nk2NFjd87vZZ/pz4cb+Z+CT5u4noDxT?=
 =?us-ascii?Q?g/PsBr1CtRnvc9W4YSM08lA2Rt/n+XuYA260HNznB8+TYZcGt1VpDYhtNe+f?=
 =?us-ascii?Q?u+ey2aLTTpyXD0CGoJPLFSDv5l8nWjvmN+AlbiC8vdj97fp8w/2WiVJZ+t5V?=
 =?us-ascii?Q?Ljigwba9QxDBKuIGsH3B2bFF/PBZRrr25JwIu3FmUhg7PilcXlV4ICIm0Haj?=
 =?us-ascii?Q?s7wcSChgH04RqVNC3e+wuxB4Xur/vZHOz5reaXHbQjLgeWDylD3vno78d7FW?=
 =?us-ascii?Q?Xa3MUScr1TnyBBrIgKEH+85FPZrnBdutuLycCVhH7GfVGWs4sUpjr8VRpprq?=
 =?us-ascii?Q?rxsk8sFkBZ4JfFH6oVZ0u4r4DzWB5RVktS9TMe2/uCC9EritF1e9auxlA4QV?=
 =?us-ascii?Q?DjPLJtNvjtYULfo30yMMKBzKHt8oYUR49A7Hj8DBBLj8grmjl1ebZWXJaVVs?=
 =?us-ascii?Q?0CvtwhX3iaQjTV5XX22KfVUWBiSZP2kd1nh1MkcOhwh+q/dpWRAVcZECOYKx?=
 =?us-ascii?Q?/NukuQvavYaCLjUOkfA9jc+rrbgUp/lt4tBMOLc48m4IbgdP8ZMINeN8SK8I?=
 =?us-ascii?Q?eIdtoMu0SzVH2pVDLmRf166sltkLjQwwrLPa0h3KLTEy1+qzoWnt/784G3QF?=
 =?us-ascii?Q?1J0PtWAno09P63i7eWsDGi5Pyrzih8goazvOtmEUhr7m+OrVUhmgddnDScqx?=
 =?us-ascii?Q?4iuLOr3lINb5Yfjm9xZpUs3r4HVo/cwaRSjnb79bZBVjGuZvlcKoZnknLuJD?=
 =?us-ascii?Q?CkaUK/oKHbR09FG+teFq6T9e5MXSTxKMcZuNM4Jo+9DYOf0zUgKY3xuS8fMF?=
 =?us-ascii?Q?YyrGCmyvgkjCBuCj5ee820NMfJPRiV3XAtPFN7Zf0pAS4RN7eTDkMKMXKvLo?=
 =?us-ascii?Q?rZ06Lxh5Lwemo7sA55IMeH1K?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2968610-f947-45bc-ac22-08d946ca7394
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2966.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2021 13:22:38.7754
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5WwbWN33R4Tah+I5nla/bU3ytQoeAWVm5eQJsGHLX27FQwMVKNDmON6UTVSCLrf8TTfmEWkvLVhzEdqoz3V18D2ZQNTNLqLsJT3DJ0tVDno=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2758
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10044 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0
 spamscore=0 suspectscore=0 adultscore=0 mlxlogscore=676 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2107140083
X-Proofpoint-GUID: IBrhh4_ICKEBv1ceQjerkONG_PfUhUCJ
X-Proofpoint-ORIG-GUID: IBrhh4_ICKEBv1ceQjerkONG_PfUhUCJ
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 14, 2021 at 07:20:39PM +0800, Zhang Qiao wrote:
> And i have another thought is that we can hold the
> hotplug lock before calling cfs_bandwidth_usage_dec().
> This way, fewer modifications are involved.
> What do you think about it?

It is fewer lines, but then hotplug lock is taken pointlessly for
!JUMP_LABEL.  Not a huge deal in a slow path like this, just a bit lame.
Adding a new variant seems cleaner if more verbose.