Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] tools: PCI: Zero-initialize param
To:     Shunyong Yang <yang.shunyong@gmail.com>, <bhelgaas@google.com>,
        <lorenzo.pieralisi@arm.com>, <kw@linux.com>, <leon@kernel.org>
CC:     <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20210714132331.5200-1-yang.shunyong@gmail.com>
From:   Kishon Vijay Abraham I <kishon@ti.com>
Message-ID: <9e40fd4c-6aec-db3e-f323-0f2cfb67d58c@ti.com>
Date:   Wed, 14 Jul 2021 19:02:46 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210714132331.5200-1-yang.shunyong@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 14/07/21 6:53 pm, Shunyong Yang wrote:
> The values in param may be random if they are not initialized, which
> may cause use_dma flag set even when "-d" option is not provided
> in command line. Initializing all members to 0 to solve this.
> 
> Signed-off-by: Shunyong Yang <yang.shunyong@gmail.com>

Thanks for the fix.

Acked-by: Kishon Vijay Abraham I <kishon@ti.com>


> ---
> v2: Change {0} to {} as Leon Romanovsky's comment.
> ---
>  tools/pci/pcitest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
> index 0a1344c45213..441b54234635 100644
> --- a/tools/pci/pcitest.c
> +++ b/tools/pci/pcitest.c
> @@ -40,7 +40,7 @@ struct pci_test {
>  
>  static int run_test(struct pci_test *test)
>  {
> -	struct pci_endpoint_test_xfer_param param;
> +	struct pci_endpoint_test_xfer_param param = {};
>  	int ret = -EINVAL;
>  	int fd;
>  
>