Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1626253775.git.mchehab+huawei@kernel.org> <1e7ec01a61916a03e7165e684d8d5b7dc58970f0.1626253775.git.mchehab+huawei@kernel.org>
In-Reply-To: <1e7ec01a61916a03e7165e684d8d5b7dc58970f0.1626253775.git.mchehab+huawei@kernel.org>
From:   Rob Herring <robh@kernel.org>
Date:   Wed, 14 Jul 2021 07:36:43 -0600
Message-ID: <CAL_JsqJKkLZH7GnhFh=oznFnK+j2b7VVjsfWAWZq47TkqDayOw@mail.gmail.com>
Subject: Re: [PATCH v13 1/9] staging: hi6421-spmi-pmic: rename GPIO IRQ OF node
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linuxarm <linuxarm@huawei.com>, mauro.chehab@huawei.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-staging@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jul 14, 2021 at 3:13 AM Mauro Carvalho Chehab
<mchehab+huawei@kernel.org> wrote:
>
> Instead of using the standard name ("gpios"), use "interrupts".
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
>  drivers/staging/hikey9xx/hi6421-spmi-pmic.c              | 2 +-
>  drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
> index 35ef3d4c760b..9a7e095246f7 100644
> --- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
> +++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
> @@ -233,7 +233,7 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev)
>
>         ddata->dev = dev;
>
> -       ddata->gpio = of_get_gpio(np, 0);
> +       ddata->gpio = of_get_named_gpio_flags(np, "interrupts", 0, NULL);

It's an interrupt, you should be using platform_get_irq() and
devm_request_irq().

In general, you should not be using of_get_* for any resources, but
use the firmware agnostic flavors.

>         if (ddata->gpio < 0)
>                 return ddata->gpio;
>
> diff --git a/drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml b/drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml
> index 8e355cddd437..252b600f02a8 100644
> --- a/drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml
> +++ b/drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml
> @@ -34,7 +34,7 @@ properties:
>
>    interrupt-controller: true
>
> -  gpios:
> +  interrupts:
>      maxItems: 1
>      description: GPIO used for IRQs
>
> @@ -71,7 +71,7 @@ examples:
>
>        #interrupt-cells = <2>;
>        interrupt-controller;
> -      gpios = <&gpio28 0 0>;
> +      interrupts = <&gpio28 0 0>;
>
>        regulators {
>          #address-cells = <1>;
> --
> 2.31.1
>