Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp448661pxv; Wed, 14 Jul 2021 07:38:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyurzBSunnxMPeWBj7zaZLwpvnayPC7XblU8RqOBggpo3jn8/u05dksGN20KcQbCJrlY13 X-Received: by 2002:a05:6602:1216:: with SMTP id y22mr7423831iot.22.1626273527943; Wed, 14 Jul 2021 07:38:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626273527; cv=none; d=google.com; s=arc-20160816; b=bbmtMoFCsxuFiHemAlAlbfkRyY6BuU4FG+dsvAQsWAYkbnY+tY6DVkCXscwtmHu5bC SUezr2uEyE7LgInxZE+C/7WFVlOExtfE7+VzurQsfG1ewtlCq6DUkJIwBHUzjgwpNWkT HNPKQyvVUtEKMHdlopfOq0iJx7n/sUVMvTOfK44FbFKVOPnetd51eX+7IunLb6ofaH7h AbhCryvZh+kJMAz4JMVRVcIp65h6ZwffVU3vRSu82vSqmXD51rJaYI9NH8pXD9JVpxSj LNSctoyutAzGCKMbqIa7MK5eZu/8Fd+2YfzYAcFHEyWA5hq9T0n5rFsfT9PITE4useDM xXTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=+k7KOCPI7OGD1hlosIo++gaqR/q1dsrK1qYsF3hN3G0=; b=CRXNCLnXDUl7ZxT2l/ux+zC+6i/IK+ehgc+cor2Xo8H9FTvBbxztfG7L+ywt9nnkOY S2sb1RrnT5q8BcPSKupm7+SpETePJ+xwvERQMSzwzP09X+OYnsypqneolV5Vi5tpKFvq 8KfSI64K36s4tS9Rae8GeqyK61Dp7st0mOPrSr3nDmdrCp8LQXIEHMBOFQqqvarM3iu9 CSJ4x/bEmX/Zyq+NgpPXUbQPTcOtQtGuoNLZM+crlkUqqcuuvFY8AUU2+fVIVR9ATCjb DSMbsQF7e3tLTkIMISimHgXyRhGzVa8Z1nEGDyLG/hah9GdQqQfWIu6h85bJZEWaIQhE hfxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z7si2963536jap.105.2021.07.14.07.38.35; Wed, 14 Jul 2021 07:38:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232129AbhGNOk5 (ORCPT + 99 others); Wed, 14 Jul 2021 10:40:57 -0400 Received: from foss.arm.com ([217.140.110.172]:35658 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231977AbhGNOk5 (ORCPT ); Wed, 14 Jul 2021 10:40:57 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9951C31B; Wed, 14 Jul 2021 07:38:05 -0700 (PDT) Received: from [10.57.36.240] (unknown [10.57.36.240]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CBDF53F694; Wed, 14 Jul 2021 07:38:03 -0700 (PDT) Subject: Re: [PATCH v1] arm64: dts: imx8qm: added System MMU To: Oliver Graute , shawnguo@kernel.org Cc: devicetree@vger.kernel.org, aisheng.dong@nxp.com, fabio.estevam@nxp.com, Rob Herring , Sascha Hauer , Sascha Hauer , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210714120925.23571-1-oliver.graute@kococonnector.com> <20210714120925.23571-3-oliver.graute@kococonnector.com> From: Robin Murphy Message-ID: Date: Wed, 14 Jul 2021 15:37:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210714120925.23571-3-oliver.graute@kococonnector.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-07-14 13:09, Oliver Graute wrote: > added node for System MMU Note that it's a bit of a dangerous game to enable an SMMU without the complete Stream ID topology for *all* its upstream devices also described, since CONFIG_ARM_SMMU_DISABLE_BYPASS_BY_DEFAULT will ruin peoples' day. It might be more polite to add it in a disabled state until every "iommus" property has been filled in, so that people who do want to play with it for specific devices in the meantime can easily just flip the status (while taking the necessary precautions), but people who don't care won't be inadvertently affected regardless of their kernel config. I'm assuming an SMMU with 32 contexts has more than a single USB controller behind it... Robin. > Cc: Rob Herring > Cc: Sascha Hauer > Cc: Fabio Estevam > Cc: Dong Aisheng > > Signed-off-by: Oliver Graute > --- > arch/arm64/boot/dts/freescale/imx8qm.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi > index 7efc0add74ea..fa827ed04e09 100644 > --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi > @@ -140,6 +140,23 @@ > method = "smc"; > }; > > + smmu: iommu@51400000 { > + compatible = "arm,mmu-500"; > + interrupt-parent = <&gic>; > + reg = <0 0x51400000 0 0x40000>; > + #global-interrupts = <1>; > + #iommu-cells = <2>; > + interrupts = <0 32 4>, > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>, > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>, > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>, > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>, > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>, > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>, > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>, > + <0 32 4>, <0 32 4>, <0 32 4>, <0 32 4>; > + }; > + > timer { > compatible = "arm,armv8-timer"; > interrupts = , /* Physical Secure */ >