Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 14 Jul 2021 17:02:18 +0200
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>
Cc:     "Kirill A. Shutemov" <kirill@shutemov.name>, airlied@linux.ie,
        daniel@ffwll.ch, Alistair Popple <apopple@nvidia.com>,
        Corentin Labbe <clabbe.montjoie@gmail.com>, bskeggs@redhat.com,
        dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: Re: nouveau: failed to initialise sync
Message-ID: <YO78eo/MNcPMYAgC@phenom.ffwll.local>
Mail-Followup-To: Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
        "Kirill A. Shutemov" <kirill@shutemov.name>, airlied@linux.ie,
        Alistair Popple <apopple@nvidia.com>,
        Corentin Labbe <clabbe.montjoie@gmail.com>, bskeggs@redhat.com,
        dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <YOC4uekpD7iA3xPi@Red>
 <1682547.0nLxAY2a9E@nvdebian>
 <dace0dea-7ca9-99cb-ad80-106824cb5e3f@amd.com>
 <20210714125652.eohw2s2pncplxovx@box.shutemov.name>
 <8fd70eb5-7306-89a3-57f9-d633243c9df5@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8fd70eb5-7306-89a3-57f9-d633243c9df5@amd.com>
Precedence: bulk

On Wed, Jul 14, 2021 at 03:02:21PM +0200, Christian K?nig wrote:
> Am 14.07.21 um 14:56 schrieb Kirill A. Shutemov:
> > On Tue, Jul 06, 2021 at 08:58:37AM +0200, Christian K?nig wrote:
> > > Hi guys,
> > > 
> > > yes nouveau was using the same functionality for internal BOs without
> > > noticing it. This is fixes by the following commit:
> > > 
> > > commit d098775ed44021293b1962dea61efb19297b8d02
> > > Author: Christian K?nig <christian.koenig@amd.com>
> > > Date:?? Wed Jun 9 19:25:56 2021 +0200
> > > 
> > >  ??? drm/nouveau: init the base GEM fields for internal BOs
> > > 
> > >  ??? TTMs buffer objects are based on GEM objects for quite a while
> > >  ??? and rely on initializing those fields before initializing the TTM BO.
> > > 
> > >  ??? Nouveau now doesn't init the GEM object for internally allocated BOs,
> > >  ??? so make sure that we at least initialize some necessary fields.
> > > 
> > > Could be that the patch needs to be send to stable as well.
> > The regression is present in v5.14-rc1. Any idea when it will hit
> > upstream? I don't see it being applied to drm=next.
> 
> Well that question needs to answer Dave or somebody else from the drm-misc
> maintainer team.
> 
> This fix together with some others are already in drm-misc-next-fixes
> waiting to be pushed upstream, but it looks like that hasn't happened yet.
> 
> Even Linus already pinged me where the fix for qxl got stuck.

Yeah there was some missed patches. drm-misc-fixes is now in drm-fixes,
and drm-misc-next-fixes is included in drm-misc-fixes, for which Thomas
will do a pull request on Thu so it will land in -rc2.

It should also now be in linux-next.

But yes somehow bugfixes got a bit lost during the merge window.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch