Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp505722pxv; Wed, 14 Jul 2021 08:53:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2rL8NG93F6SY8dJEga7gjgirtP79L1+T+L3o6XjtFxbCg0aViap7B8/yAEpTbRoQMk2lx X-Received: by 2002:a05:6402:22f4:: with SMTP id dn20mr14291529edb.335.1626278034333; Wed, 14 Jul 2021 08:53:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626278034; cv=none; d=google.com; s=arc-20160816; b=FCH5tVYSfKtzkERon/KHOQ1eurTP7HzXfCQ4mVH6WcjMq9T2PPZEMgc/6DlTkNH9gA idJWQG5yebOKxc/6wzSeuJCpufh+A18uQQLtX0QaEzKFlhK5XNRq3hrA1CQaBBp1+Ex8 hFEV2sqXpWNxU1KWe+V966glxKq++Fe7qj4tebmNliQRXJcdHpccqLLVaZqeoZmLq4qa 1c7R6WYsl/4HwOqsXsdkxKpITVsX6zqbxI3QML0UBk4g7rly6Ma1SA5e3cSclUD3XFLA YcxBFvh1A86jUkabwgILsbBqUiiXfRlZS5limubk5wmM2Zkwmycptc0WQrCCe3SUVs5J TrrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ipmtRUIgf3L0in0VPeRm8RyFb6KTk8DzNVYnk43l6F4=; b=nBCFK8KnylB67c/wQPhPMErE66LNOvq9X+LhaugSPmO8FK51zCycZAfGHvCWlA/MTz FaWa8Z3RAtvQ2CzNY4e4DSXgq6Qk7eqJXCzwZXG3/ramS6B4AG8x+5oc2ndRVI1KNB7z 3ZCSUl+JYvuyzZIee7e/5x7WZP5pFs1i5sN4kjN3qeHhXXjhQOZzS8WgTzqWk4c3jYHT 7rxNxTzlceq5A2OsfgouJLxm44lolDao3WfqiODPVPPOCEdxpASBwL0p2B4dqp0GhLvb ahN5Pp4gPTXzty3qd6GZ/E9P1s/DY7ExtVWO9aZJv8ZpiUh4NFoD1deNuN7xXdWOEUgn OY8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=XzleKI3T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp16si3727389ejc.434.2021.07.14.08.53.30; Wed, 14 Jul 2021 08:53:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=XzleKI3T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239711AbhGNPxH (ORCPT + 99 others); Wed, 14 Jul 2021 11:53:07 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35653 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239625AbhGNPxH (ORCPT ); Wed, 14 Jul 2021 11:53:07 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7063F5C017D; Wed, 14 Jul 2021 11:50:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 14 Jul 2021 11:50:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ipmtRU Igf3L0in0VPeRm8RyFb6KTk8DzNVYnk43l6F4=; b=XzleKI3T9tGTqYto49SUZ/ 0Ogn296RCdDA5VKZF67nQEYwHOkt/j8OvIr6/S3ykMz0lowucHMdM+VvBQWnQH9+ JRJ+u/EW2zxx9WU8pakPxVGC1fQj1Dgz1SgDrBYJBw1N3BOQxa6WZIAG2yM2UqR4 ILi3vg++owqKcd6pHHPXXrFUKu7+z0qniK7AUZtfD3rHHZSM5kkv1+zOH/k858YA f39ixV6fgIPFqvJ3NmRnzB2zGsuUqn3ZzSwgga2HN0NCiGD/itc68PhKHdNBAcQV /9rd79jqG2XUlJFjHwStxf2HRz4kPNCTE6+Nzsvb5qkOrRL+4JQR0X+4ghSbw2oQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekgdeltdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcuufgt hhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrthhtvg hrnhepgfevgfevueduueffieffheeifffgjeelvedtteeuteeuffekvefggfdtudfgkeev necuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Jul 2021 11:50:14 -0400 (EDT) Date: Wed, 14 Jul 2021 18:50:09 +0300 From: Ido Schimmel To: Christophe JAILLET Cc: jiri@nvidia.com, idosch@nvidia.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] net: switchdev: Simplify 'mlxsw_sp_mc_write_mdb_entry()' Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 14, 2021 at 10:32:33AM +0200, Christophe JAILLET wrote: > Use 'bitmap_alloc()/bitmap_free()' instead of hand-writing it. > This makes the code less verbose. > > Also, use 'bitmap_alloc()' instead of 'bitmap_zalloc()' because the bitmap > is fully overridden by a 'bitmap_copy()' call just after its allocation. > > While at it, remove an extra and unneeded space. > > Signed-off-by: Christophe JAILLET For net-next: Reviewed-by: Ido Schimmel Note that net-next is closed [1] so you might need to re-submit, if it does not open soon. Thanks for the patch. [1] http://vger.kernel.org/~davem/net-next.html