Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp545236pxv; Wed, 14 Jul 2021 09:40:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwv9+YhqW7KaMPZVAnyQbNkGc3wtReAR7K8ZJVmYMX8Z5XMelpS8KOwiXjqRIGSFyMD65a+ X-Received: by 2002:a17:906:5650:: with SMTP id v16mr13262352ejr.533.1626280824647; Wed, 14 Jul 2021 09:40:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626280824; cv=none; d=google.com; s=arc-20160816; b=pmBaSer5Xv2LB3X0yT1lAqJK5WIY4MMfQYOqwwF96Eqc9cGOKJf3E7G60/vaaI247w uGUHrPbzrLq9s1dFiGhN0abdjoZ8leT7GoexM7SByRCTxh6LpDj+VsadyPKrHamzGKji kK+HYpcMnoI/29gxBKmM648gvC1mJBm4cHPiuPw+8NKy2BgbBlgzd2VOJ+LE2El7Vsr2 LwhD5slUtN/L7oYxEVs0fn3HgLaUL2SdshhG5eBdOLSHLTpZ1OdmmZ/SAK//TPDsWe0h zGV1GTM2r0AvM9vBJLkudjgGZSqp9JU/jZfb4PQvKaEZMSZiBDHx7hxMsnNX4Qv5XI+l l/3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=0ySFjjWA9wFhBj1ettZImQId0K8qxGfc0nzfdyL34OE=; b=OXWErsNRN/nrUV+9NlvpgaPj/k1n8qbt/Os35+40pDoOFkdUE29IhOjyTvlWUm5bR3 KqS29/LY1U0PiBOhobBrGi/QaRODKnwZwtjcimYTZQE+RfPZ09e9vmKKe7imnMNXp3FU O4TNM1WXyfIcsO0YXL0MI3DCCCOOlae+fnBY/dCUKcZ4p+mMLjXF34nmeyfJrmgcFOI2 VSSuhQ8TzQCakcKJaq6qoCYCW1cpz+pv53ksfkNyjWpFOeJmjIRylAAs75EooBMilbJM +b4WjHniYfDO+5GipzZCOryC6vGfZRkqStTzxwQmy1nkKBSOpT1qtA1x25Ii2PcperWW Gtyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y4si3290811edi.355.2021.07.14.09.40.01; Wed, 14 Jul 2021 09:40:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230481AbhGNQlS (ORCPT + 99 others); Wed, 14 Jul 2021 12:41:18 -0400 Received: from foss.arm.com ([217.140.110.172]:36864 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhGNQlS (ORCPT ); Wed, 14 Jul 2021 12:41:18 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 25239D6E; Wed, 14 Jul 2021 09:38:26 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6B3083F7D8; Wed, 14 Jul 2021 09:38:25 -0700 (PDT) From: Sudeep Holla To: Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Sudeep Holla Subject: Re: [PATCH] firmware: arm_scmi: Avoid padding in sensor message structure Date: Wed, 14 Jul 2021 17:38:21 +0100 Message-Id: <162628065273.2615991.7447656949078196138.b4-ty@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210628170042.34105-1-cristian.marussi@arm.com> References: <20210628170042.34105-1-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Jun 2021 18:00:42 +0100, Cristian Marussi wrote: > Structure scmi_resp_sensor_reading_complete is meant to represent an SCMI > asynchronous reading complete message: representing the readings field with > a 64bit type forces padding and breaks reads in scmi_sensor_reading_get. > > Split it in two adjacent 32bit readings_low/high subfields to avoid padding > or the need to make it packed. Applied to sudeep.holla/linux (for-next/scmi), thanks! [1/1] firmware: arm_scmi: Avoid padding in sensor message structure https://git.kernel.org/sudeep.holla/c/187a002b07 -- Regards, Sudeep