Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <63a72f648297e96c140a1412c20bd3796398a932.camel@buserror.net>
From:   Scott Wood <oss@buserror.net>
To:     Pali =?ISO-8859-1?Q?Roh=E1r?= <pali@kernel.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Russell King <linux@armlinux.org.uk>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        "Camelia Alexandra Groza (OSS)" <camelia.groza@oss.nxp.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Marek =?ISO-8859-1?Q?Beh=FAn?= <kabel@kernel.org>,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Wed, 14 Jul 2021 12:11:49 -0500
In-Reply-To: <20210704134325.24842-1-pali@kernel.org>
References: <20210604233455.fwcu2chlsed2gwmu@pali>
         <20210704134325.24842-1-pali@kernel.org>
Organization: Red Hat
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH] powerpc/fsl/dts: Fix phy-connection-type for fm1mac3
Precedence: bulk

On Sun, 2021-07-04 at 15:43 +0200, Pali Rohár wrote:
> Property phy-connection-type contains invalid value "sgmii-2500" per scheme
> defined in file ethernet-controller.yaml.
> 
> Correct phy-connection-type value should be "2500base-x".
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Fixes: 84e0f1c13806 ("powerpc/mpc85xx: Add MDIO bus muxing support to the
> board device tree(s)")
> ---
>  arch/powerpc/boot/dts/fsl/t1023rdb.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> b/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> index 5ba6fbfca274..f82f85c65964 100644
> --- a/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> +++ b/arch/powerpc/boot/dts/fsl/t1023rdb.dts
> @@ -154,7 +154,7 @@
>  
>                         fm1mac3: ethernet@e4000 {
>                                 phy-handle = <&sgmii_aqr_phy3>;
> -                               phy-connection-type = "sgmii-2500";
> +                               phy-connection-type = "2500base-x";
>                                 sleep = <&rcpm 0x20000000>;
>                         };
>  

Acked-by: Scott Wood <oss@buserror.net>

-Scott