Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 14 Jul 2021 18:44:19 +0100
From:   Cristian Marussi <cristian.marussi@arm.com>
To:     Sudeep Holla <sudeep.holla@arm.com>
Cc:     linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Jassi Brar <jassisinghbrar@gmail.com>
Subject: Re: [PATCH 04/13] mailbox: pcc: Consolidate subspace interrupt
 information parsing
Message-ID: <20210714174419.GA49078@e120937-lin>
References: <20210708180851.2311192-1-sudeep.holla@arm.com>
 <20210708180851.2311192-5-sudeep.holla@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210708180851.2311192-5-sudeep.holla@arm.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Thu, Jul 08, 2021 at 07:08:42PM +0100, Sudeep Holla wrote:
> Extended PCC subspaces(Type 3 and 4) differs from generic(Type 0) and

nit: s/differs/differ

> HW-Reduced Communication(Type 1 and 2) subspace structures. However some
> fields share same offsets and same type of structure can be use to extract
> the fields. In order to simplify that, let us move all the IRQ related
> information parsing into pcc_parse_subspace_irq and consolidate there.
> It will be easier to extend it if required within the same.
> 
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/mailbox/pcc.c | 38 +++++++++++++++++++-------------------
>  1 file changed, 19 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index c5f481a615b0..55866676a508 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -404,18 +404,26 @@ static int parse_pcc_subspace(union acpi_subtable_headers *header,
>  
>  /**
>   * pcc_parse_subspace_irq - Parse the PCC IRQ and PCC ACK register
> - *		There should be one entry per PCC client.
> - * @id: PCC subspace index.
> - * @pcct_ss: Pointer to the ACPI subtable header under the PCCT.
> + *
> + * @pchan: Pointer to the PCC channel info structure.
> + * @pcct_entry: Pointer to the ACPI subtable header.
>   *
>   * Return: 0 for Success, else errno.
>   *
> - * This gets called for each entry in the PCC table.
> + * There should be one entry per PCC channel. This gets called for each
> + * entry in the PCC table. This uses PCCY Type1 structure for all applicable
> + * types(Type 1 -4) to fetch irq
>   */
> -static int pcc_parse_subspace_irq(int id, struct acpi_pcct_hw_reduced *pcct_ss)
> +static int pcc_parse_subspace_irq(struct pcc_chan_info *pchan,
> +				  struct acpi_subtable_header *pcct_entry)
>  {
> -	struct pcc_chan_info *pchan = chan_info + id;
> +	struct acpi_pcct_hw_reduced *pcct_ss;
>  
> +	if (pcct_entry->type < ACPI_PCCT_TYPE_HW_REDUCED_SUBSPACE ||
> +	    pcct_entry->type > ACPI_PCCT_TYPE_EXT_PCC_SLAVE_SUBSPACE)
> +		return 0;
> +
> +	pcct_ss = (struct acpi_pcct_hw_reduced *)pcct_entry;
>  	pchan->db_irq = pcc_map_interrupt(pcct_ss->platform_interrupt,
>  					  (u32)pcct_ss->flags);
>  	if (pchan->db_irq <= 0) {
> @@ -424,8 +432,7 @@ static int pcc_parse_subspace_irq(int id, struct acpi_pcct_hw_reduced *pcct_ss)
>  		return -EINVAL;
>  	}
>  
> -	if (pcct_ss->header.type
> -		== ACPI_PCCT_TYPE_HW_REDUCED_SUBSPACE_TYPE2) {
> +	if (pcct_ss->header.type == ACPI_PCCT_TYPE_HW_REDUCED_SUBSPACE_TYPE2) {
>  		struct acpi_pcct_hw_reduced_type2 *pcct2_ss = (void *)pcct_ss;
>  
>  		pchan->db_ack_vaddr =
> @@ -509,17 +516,10 @@ static int __init acpi_pcc_probe(void)
>  		struct acpi_pcct_subspace *pcct_ss;
>  		pcc_mbox_channels[i].con_priv = pcct_entry;
>  
> -		if (pcct_entry->type == ACPI_PCCT_TYPE_HW_REDUCED_SUBSPACE ||
> -		    pcct_entry->type == ACPI_PCCT_TYPE_HW_REDUCED_SUBSPACE_TYPE2) {
> -			struct acpi_pcct_hw_reduced *pcct_hrss;
> -
> -			pcct_hrss = (struct acpi_pcct_hw_reduced *) pcct_entry;
> -
> -			if (pcc_mbox_ctrl.txdone_irq) {
> -				rc = pcc_parse_subspace_irq(i, pcct_hrss);
> -				if (rc < 0)
> -					goto err;
> -			}
> +		if (pcc_mbox_ctrl.txdone_irq) {
> +			rc = pcc_parse_subspace_irq(pchan, pcct_entry);
> +			if (rc < 0)
> +				goto err;
>  		}
>  		pcct_ss = (struct acpi_pcct_subspace *) pcct_entry;
>  
> -- 
> 2.25.1

Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks,
Cristian